refactor: precompute resource counts and add return type annotation
Avoid recalculating per-resource counts 3x per table row by precomputing them into a Map. Add explicit ResultCounts return type to resourceCounts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -13,6 +13,7 @@ import {
|
|||||||
countResultsForItems,
|
countResultsForItems,
|
||||||
filterResultsByNamespace,
|
filterResultsByNamespace,
|
||||||
Result,
|
Result,
|
||||||
|
ResultCounts,
|
||||||
} from '../api/polaris';
|
} from '../api/polaris';
|
||||||
import { usePolarisDataContext } from '../api/PolarisDataContext';
|
import { usePolarisDataContext } from '../api/PolarisDataContext';
|
||||||
|
|
||||||
@@ -22,9 +23,8 @@ function scoreStatus(score: number): 'success' | 'warning' | 'error' {
|
|||||||
return 'error';
|
return 'error';
|
||||||
}
|
}
|
||||||
|
|
||||||
function resourceCounts(result: Result) {
|
function resourceCounts(result: Result): ResultCounts {
|
||||||
const counts = countResultsForItems([result]);
|
return countResultsForItems([result]);
|
||||||
return counts;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export default function NamespaceDetailView() {
|
export default function NamespaceDetailView() {
|
||||||
@@ -69,6 +69,15 @@ export default function NamespaceDetailView() {
|
|||||||
const score = computeScore(counts);
|
const score = computeScore(counts);
|
||||||
const status = scoreStatus(score);
|
const status = scoreStatus(score);
|
||||||
|
|
||||||
|
const countsPerResource = new Map<string, ResultCounts>();
|
||||||
|
for (const r of results) {
|
||||||
|
countsPerResource.set(`${r.Namespace}/${r.Kind}/${r.Name}`, resourceCounts(r));
|
||||||
|
}
|
||||||
|
|
||||||
|
function getResourceCounts(row: Result): ResultCounts {
|
||||||
|
return countsPerResource.get(`${row.Namespace}/${row.Kind}/${row.Name}`) ?? resourceCounts(row);
|
||||||
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
<SectionHeader title={`Polaris — ${namespace}`} />
|
<SectionHeader title={`Polaris — ${namespace}`} />
|
||||||
@@ -104,24 +113,21 @@ export default function NamespaceDetailView() {
|
|||||||
{ label: 'Kind', getter: (row: Result) => row.Kind },
|
{ label: 'Kind', getter: (row: Result) => row.Kind },
|
||||||
{
|
{
|
||||||
label: 'Pass',
|
label: 'Pass',
|
||||||
getter: (row: Result) => {
|
getter: (row: Result) => (
|
||||||
const c = resourceCounts(row);
|
<StatusLabel status="success">{getResourceCounts(row).pass}</StatusLabel>
|
||||||
return <StatusLabel status="success">{c.pass}</StatusLabel>;
|
),
|
||||||
},
|
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Warning',
|
label: 'Warning',
|
||||||
getter: (row: Result) => {
|
getter: (row: Result) => (
|
||||||
const c = resourceCounts(row);
|
<StatusLabel status="warning">{getResourceCounts(row).warning}</StatusLabel>
|
||||||
return <StatusLabel status="warning">{c.warning}</StatusLabel>;
|
),
|
||||||
},
|
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Danger',
|
label: 'Danger',
|
||||||
getter: (row: Result) => {
|
getter: (row: Result) => (
|
||||||
const c = resourceCounts(row);
|
<StatusLabel status="error">{getResourceCounts(row).danger}</StatusLabel>
|
||||||
return <StatusLabel status="error">{c.danger}</StatusLabel>;
|
),
|
||||||
},
|
|
||||||
},
|
},
|
||||||
]}
|
]}
|
||||||
data={results}
|
data={results}
|
||||||
|
|||||||
Reference in New Issue
Block a user