fix: match plugin settings name to deploy dir + fix badge nav URL
The registerPluginSettings name 'headlamp-polaris' didn't match the
deployed plugin directory name 'polaris', so the PolarisSettings
component never rendered on the settings page (all 5 settings E2E
tests failed).
Router.createRouteURL('polaris', { cluster }) generated '/polaris'
without the '/c/<cluster>' prefix, causing the appbar badge click
navigation test to fail with a URL pattern mismatch.
- Change registerPluginSettings name from 'headlamp-polaris' to 'polaris'
- Build badge navigation URL manually with cluster prefix
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { K8s, Router } from '@kinvolk/headlamp-plugin/lib';
|
||||
import { K8s } from '@kinvolk/headlamp-plugin/lib';
|
||||
import { useTheme } from '@mui/material/styles';
|
||||
import React from 'react';
|
||||
import { useHistory } from 'react-router-dom';
|
||||
@@ -36,7 +36,8 @@ export default function AppBarScoreBadge() {
|
||||
};
|
||||
|
||||
const handleClick = () => {
|
||||
history.push(Router.createRouteURL('polaris', { cluster: cluster ?? '' }));
|
||||
const prefix = cluster ? `/c/${cluster}` : '';
|
||||
history.push(`${prefix}/polaris`);
|
||||
};
|
||||
|
||||
return (
|
||||
|
||||
+1
-1
@@ -99,7 +99,7 @@ registerRoute({
|
||||
});
|
||||
|
||||
// Register plugin settings
|
||||
registerPluginSettings('headlamp-polaris', PolarisSettings, true);
|
||||
registerPluginSettings('polaris', PolarisSettings, true);
|
||||
|
||||
// Register details view section for supported controller types
|
||||
registerDetailsViewSection(({ resource }) => {
|
||||
|
||||
Reference in New Issue
Block a user