privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

TypeScript errors in PolarisErrorBoundary #39

New Issue
Closed
opened 2026-03-13 20:34:13 +00:00 by ghost · 2 comments
ghost commented 2026-03-13 20:34:13 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Description:
TypeScript compilation fails with errors in src/index.tsx related to the PolarisErrorBoundary class component.

Errors:

src/index.tsx(41,17): error TS2339: Property 'props' does not exist on type 'PolarisErrorBoundary'.
src/index.tsx(79,6): error TS2786: 'PolarisErrorBoundary' cannot be used as a JSX component.

Steps to reproduce:

  1. Clone the repo
  2. Run npm install
  3. Run npm run tsc

Expected: TypeScript should compile without errors
Actual: 5 TypeScript errors related to React.Component typing

Tests: 77 unit tests pass

Additional context:

  • React version: 18.3.1
  • Issue appears to be a React 18 + TypeScript type compatibility issue with class components
  • The error boundary works at runtime (tests pass), but TypeScript types are misaligned
**Description:** TypeScript compilation fails with errors in `src/index.tsx` related to the `PolarisErrorBoundary` class component. **Errors:** ``` src/index.tsx(41,17): error TS2339: Property 'props' does not exist on type 'PolarisErrorBoundary'. src/index.tsx(79,6): error TS2786: 'PolarisErrorBoundary' cannot be used as a JSX component. ``` **Steps to reproduce:** 1. Clone the repo 2. Run `npm install` 3. Run `npm run tsc` **Expected:** TypeScript should compile without errors **Actual:** 5 TypeScript errors related to React.Component typing **Tests:** 77 unit tests pass **Additional context:** - React version: 18.3.1 - Issue appears to be a React 18 + TypeScript type compatibility issue with class components - The error boundary works at runtime (tests pass), but TypeScript types are misaligned
ghost commented 2026-03-13 22:33:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Cannot Reproduce — TypeScript Compiles Clean

I investigated this issue thoroughly:

  • npm run tsc (tsc --noEmit) passes with zero errors (TypeScript 5.6.2)
  • All 77 unit tests pass
  • PolarisErrorBoundary already has correct generic params: extends React.Component<{ children: React.ReactNode }, ErrorBoundaryState>

The reported errors (TS2339: Property 'props' does not exist, TS2786: cannot be used as a JSX component) would occur if the class lacked explicit generic type parameters, but the current code already has them.

This may have been resolved by PR #37 (which removed stale type references from tsconfig.json) or was environment-specific. Closing as fixed.

Verification steps:

npm ci --include=dev
npm run tsc     # clean
npm run test    # 77/77 pass
## Cannot Reproduce — TypeScript Compiles Clean I investigated this issue thoroughly: - `npm run tsc` (`tsc --noEmit`) passes with zero errors (TypeScript 5.6.2) - All 77 unit tests pass - `PolarisErrorBoundary` already has correct generic params: `extends React.Component<{ children: React.ReactNode }, ErrorBoundaryState>` The reported errors (`TS2339: Property 'props' does not exist`, `TS2786: cannot be used as a JSX component`) would occur if the class lacked explicit generic type parameters, but the current code already has them. This may have been resolved by PR #37 (which removed stale type references from `tsconfig.json`) or was environment-specific. Closing as fixed. **Verification steps:** ``` npm ci --include=dev npm run tsc # clean npm run test # 77/77 pass ```
ghost commented 2026-03-13 22:33:24 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — cannot reproduce. TypeScript compiles clean on current main.

Closing — cannot reproduce. TypeScript compiles clean on current main.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label bug typescript
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#39
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?