privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

docs: remove manual install sections from README #61

Merged
ghost merged 1 commits from docs/remove-manual-install into main 2026-03-17 17:04:35 +00:00
Conversation 6 Commits 1 Files Changed 1
+7 -52
ghost commented 2026-03-17 12:16:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Remove manual tarball, sidecar, and build-from-source installation options from README
  • Keep only the Headlamp Plugin Manager (ArtifactHub) install path
  • Clean up section headers (remove dangling "Option 1:" numbering)

Why

Company policy: ArtifactHub plugin installer is the ONLY supported installation method. Docs must match policy.

Test plan

  • Verify README renders correctly on GitHub
  • Confirm no broken links or orphaned references

🤖 Generated with Claude Code

## Summary - Remove manual tarball, sidecar, and build-from-source installation options from README - Keep only the Headlamp Plugin Manager (ArtifactHub) install path - Clean up section headers (remove dangling "Option 1:" numbering) ## Why Company policy: ArtifactHub plugin installer is the ONLY supported installation method. Docs must match policy. ## Test plan - [ ] Verify README renders correctly on GitHub - [ ] Confirm no broken links or orphaned references 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Chris Farhood requested changes 2026-03-17 12:24:37 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

This PR is supposed to be docs-only (remove manual install sections from README), but the diff includes source code changes from PR #56 (AppBarScoreBadge.tsx, index.tsx, tests). Merging this would bypass the review process for PR #56.

Rebase this branch onto main so it only contains the README changes. Do NOT include code from other branches.

This PR is supposed to be docs-only (remove manual install sections from README), but the diff includes source code changes from PR #56 (AppBarScoreBadge.tsx, index.tsx, tests). Merging this would bypass the review process for PR #56. Rebase this branch onto main so it only contains the README changes. Do NOT include code from other branches.
Chris Farhood reviewed 2026-03-17 12:28:47 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: PR #61 - Remove manual install sections from README

Summary

README changes are correct - manual install sections (Options 2-4) have been removed, keeping only ArtifactHub/Plugin Manager path.

What was verified:

  • README renders correctly on GitHub - PASSED
  • No broken links or orphaned references - PASSED
  • Section headers are clean - PASSED (no dangling "Option 1:" numbering)
  • Installation instructions are clear - PASSED
  • CI passes - PASSED

Concern:

This PR includes unrelated code changes to:

  • src/components/AppBarScoreBadge.test.tsx
  • src/components/AppBarScoreBadge.tsx
  • src/index.tsx

Recommendation: These code changes should be in a separate PR. The README-only changes look good but the unrelated code changes make this PR larger than necessary.

Recommendation:

Request changes - split out the code changes to a separate PR.

## QA Review: PR #61 - Remove manual install sections from README ### Summary README changes are correct - manual install sections (Options 2-4) have been removed, keeping only ArtifactHub/Plugin Manager path. ### What was verified: - README renders correctly on GitHub - PASSED - No broken links or orphaned references - PASSED - Section headers are clean - PASSED (no dangling "Option 1:" numbering) - Installation instructions are clear - PASSED - CI passes - PASSED ### Concern: This PR includes unrelated code changes to: - src/components/AppBarScoreBadge.test.tsx - src/components/AppBarScoreBadge.tsx - src/index.tsx Recommendation: These code changes should be in a separate PR. The README-only changes look good but the unrelated code changes make this PR larger than necessary. ### Recommendation: Request changes - split out the code changes to a separate PR.
ghost commented 2026-03-17 16:29:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Rebased onto clean main — branch now contains only the README change. The unrelated code from PR #56 has been removed.

Rebased onto clean main — branch now contains only the README change. The unrelated code from PR #56 has been removed.
Chris Farhood approved these changes 2026-03-17 16:55:33 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: Approved ✅

Verified:

  • README renders correctly on GitHub - PASSED
  • No broken links or orphaned references - PASSED
  • Manual install sections removed (Options 2-4) - PASSED
  • ArtifactHub/Plugin Manager path retained - PASSED
  • Section headers clean (no dangling "Option 1:") - PASSED
  • CI passes - PASSED (unit tests + TypeScript)

Code Review:

  • README.md: Clean diff, only removes manual install options
  • No unrelated code changes included (addressed previous concern)

Status: Approved ✅

## QA Review: Approved ✅ ### Verified: - README renders correctly on GitHub - PASSED - No broken links or orphaned references - PASSED - Manual install sections removed (Options 2-4) - PASSED - ArtifactHub/Plugin Manager path retained - PASSED - Section headers clean (no dangling "Option 1:") - PASSED - CI passes - PASSED (unit tests + TypeScript) ### Code Review: - README.md: Clean diff, only removes manual install options - No unrelated code changes included (addressed previous concern) ### Status: Approved ✅
Chris Farhood approved these changes 2026-03-17 16:59:16 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: Approved ✅

Rebased version - only contains README.md changes.

Verified:

  • README renders correctly on GitHub
  • No broken links or orphaned references
  • Manual install sections removed (Options 2-4)
  • ArtifactHub/Plugin Manager path retained
  • Section headers clean (no dangling "Option 1:")
  • CI passes (unit tests + TypeScript)

Status: Approved ✅

## QA Review: Approved ✅ Rebased version - only contains README.md changes. ### Verified: - README renders correctly on GitHub - No broken links or orphaned references - Manual install sections removed (Options 2-4) - ArtifactHub/Plugin Manager path retained - Section headers clean (no dangling "Option 1:") - CI passes (unit tests + TypeScript) ### Status: Approved ✅
Chris Farhood approved these changes 2026-03-17 17:04:26 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

Clean rebase, README-only. Manual install sections removed per company policy. Approved.

Clean rebase, README-only. Manual install sections removed per company policy. Approved.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#61
Delete Branch "docs/remove-manual-install"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?