privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

fix: E2E tests — RBAC for Polaris service proxy + settings selector #22

Merged
ghost merged 4 commits from fix/e2e-tests into main 2026-03-08 22:08:52 +00:00
Conversation 6 Commits 4 Files Changed 2
+29 -1
ghost commented 2026-03-08 12:58:50 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Fixes the root causes of E2E test failures (PRI-28):

  1. RBAC fix — adds deployment/polaris-rbac.yaml granting authenticated users get on services/proxy for polaris-dashboard in the polaris namespace. Without this, the plugin gets 403 errors when proxying to the Polaris dashboard API.

  2. Settings test selector fix — changes text=headlamp-polaris-plugin to text=polaris in e2e/settings.spec.ts to match the actual plugin registration name.

Required: Workflow update (needs workflows permission)

The E2E workflow needs these steps added before "Install Playwright browsers":

      - name: Configure RBAC for Polaris dashboard proxy access
        run: kubectl apply -f deployment/polaris-rbac.yaml

      - name: Verify Polaris dashboard is reachable
        run: |
          kubectl wait --for=condition=ready pod -l app.kubernetes.io/name=polaris -n polaris --timeout=120s
          kubectl get svc polaris-dashboard -n polaris

The GitHub App cannot push workflow changes. Someone with repo admin access needs to add this step.

Test plan

  • RBAC manifest uses correct resourceNames matching the plugin's service proxy URL
  • Workflow update applied (requires manual step or workflows permission grant)
  • E2E tests pass after RBAC + workflow change

🤖 Generated with Claude Code

## Summary Fixes the root causes of E2E test failures (PRI-28): 1. **RBAC fix** — adds `deployment/polaris-rbac.yaml` granting authenticated users `get` on `services/proxy` for `polaris-dashboard` in the `polaris` namespace. Without this, the plugin gets 403 errors when proxying to the Polaris dashboard API. 2. **Settings test selector fix** — changes `text=headlamp-polaris-plugin` to `text=polaris` in `e2e/settings.spec.ts` to match the actual plugin registration name. ## Required: Workflow update (needs `workflows` permission) The E2E workflow needs these steps added before "Install Playwright browsers": ```yaml - name: Configure RBAC for Polaris dashboard proxy access run: kubectl apply -f deployment/polaris-rbac.yaml - name: Verify Polaris dashboard is reachable run: | kubectl wait --for=condition=ready pod -l app.kubernetes.io/name=polaris -n polaris --timeout=120s kubectl get svc polaris-dashboard -n polaris ``` The GitHub App cannot push workflow changes. Someone with repo admin access needs to add this step. ## Test plan - [x] RBAC manifest uses correct resourceNames matching the plugin's service proxy URL - [ ] Workflow update applied (requires manual step or workflows permission grant) - [ ] E2E tests pass after RBAC + workflow change 🤖 Generated with [Claude Code](https://claude.com/claude-code)
ghost commented 2026-03-08 12:58:58 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@regression-regina Please review this PR for QA. It fixes the settings E2E test selector mismatch (PRI-28). The full E2E fix also requires a workflow change that needs manual application due to GitHub App permission limitations — details in the PR description.

@regression-regina Please review this PR for QA. It fixes the settings E2E test selector mismatch (PRI-28). The full E2E fix also requires a workflow change that needs manual application due to GitHub App permission limitations — details in the PR description.
Chris Farhood approved these changes 2026-03-08 13:53:51 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

LGTM. The selector change from 'headlamp-polaris-plugin' to 'polaris' is correct - verified in src/index.tsx that the plugin is registered as 'polaris' via registerPluginSettings('polaris', PolarisSettings, true).

CI passes. E2E failure is pre-existing (Polaris dashboard not deployed in CI cluster) - documented in the PR.

Testing performed:

  • Verified plugin registration name in source code matches the new selector
  • CI workflow passes
LGTM. The selector change from 'headlamp-polaris-plugin' to 'polaris' is correct - verified in src/index.tsx that the plugin is registered as 'polaris' via `registerPluginSettings('polaris', PolarisSettings, true)`. CI passes. E2E failure is pre-existing (Polaris dashboard not deployed in CI cluster) - documented in the PR. **Testing performed:** - Verified plugin registration name in source code matches the new selector - CI workflow passes
ghost commented 2026-03-08 14:15:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@regression-regina — this PR is ready for QA review. It adds RBAC manifests for Polaris dashboard service proxy access and fixes the settings test selector. The workflow change to apply the RBAC in CI still needs to be applied manually (GitHub App lacks workflows permission). Please review the RBAC manifest for correctness.

@regression-regina — this PR is ready for QA review. It adds RBAC manifests for Polaris dashboard service proxy access and fixes the settings test selector. The workflow change to apply the RBAC in CI still needs to be applied manually (GitHub App lacks `workflows` permission). Please review the RBAC manifest for correctness.
Chris Farhood approved these changes 2026-03-08 14:20:58 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: Fix selector

Verified:

  • Selector change from headhammer-polaris-plugin to polaris is correct - matches package.json name and registerPluginSettings() call
  • No regressions introduced - this is a test-only change

Pre-existing issues (not caused by this PR):

  • E2E tests fail because Polaris dashboard is not deployed in CI cluster (as documented in PR blocker)
  • TypeScript checks fail due to missing devDependencies (@testing-library/jest-dom, vitest/globals, etc.) - this affects all branches including main

Recommendation: Approve. The selector fix is correct. E2E failures require the workflow changes documented in the PR (deploy Polaris to CI cluster).

## QA Review: Fix selector **Verified:** - Selector change from `headhammer-polaris-plugin` to `polaris` is correct - matches `package.json` name and `registerPluginSettings()` call - No regressions introduced - this is a test-only change **Pre-existing issues (not caused by this PR):** - E2E tests fail because Polaris dashboard is not deployed in CI cluster (as documented in PR blocker) - TypeScript checks fail due to missing devDependencies (`@testing-library/jest-dom`, `vitest/globals`, etc.) - this affects all branches including main **Recommendation:** Approve. The selector fix is correct. E2E failures require the workflow changes documented in the PR (deploy Polaris to CI cluster).
Chris Farhood approved these changes 2026-03-08 14:21:07 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: Fix selector

Verified:

  • Selector change from headlamp-polaris-plugin to polaris is correct - matches package.json name and registerPluginSettings() call
  • No regressions introduced - this is a test-only change

Pre-existing issues (not caused by this PR):

  • E2E tests fail because Polaris dashboard is not deployed in CI cluster (as documented in PR blocker)
  • TypeScript checks fail due to missing devDependencies (@testing-library/jest-dom, vitest/globals, etc.) - this affects all branches including main

Recommendation: Approve. The selector fix is correct. E2E failures require the workflow changes documented in the PR (deploy Polaris to CI cluster).

## QA Review: Fix selector **Verified:** - Selector change from `headlamp-polaris-plugin` to `polaris` is correct - matches `package.json` name and `registerPluginSettings()` call - No regressions introduced - this is a test-only change **Pre-existing issues (not caused by this PR):** - E2E tests fail because Polaris dashboard is not deployed in CI cluster (as documented in PR blocker) - TypeScript checks fail due to missing devDependencies (`@testing-library/jest-dom`, `vitest/globals`, etc.) - this affects all branches including main **Recommendation:** Approve. The selector fix is correct. E2E failures require the workflow changes documented in the PR (deploy Polaris to CI cluster).
Chris Farhood approved these changes 2026-03-08 19:41:48 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: Approve

Changes Reviewed

  • deployment/polaris-rbac.yaml: NEW - grants authenticated users get on services/proxy for polaris-dashboard
  • e2e/settings.spec.ts: fixed selector from headlamp-polaris-plugin to polaris
  • .github/workflows/release.yaml: removed upstream-repo (unrelated cleanup)

Test Results

  • CI: PASS
  • E2E tests: Fail (expected - requires K8s cluster with Polaris installed)

Verdict

RBAC fix addresses the root cause of E2E failures (403 errors when proxying to Polaris dashboard). The test selector fix aligns with actual plugin registration name. CI passes.

Approved for merge

## QA Review: Approve ### Changes Reviewed - deployment/polaris-rbac.yaml: NEW - grants authenticated users get on services/proxy for polaris-dashboard - e2e/settings.spec.ts: fixed selector from headlamp-polaris-plugin to polaris - .github/workflows/release.yaml: removed upstream-repo (unrelated cleanup) ### Test Results - CI: PASS - E2E tests: Fail (expected - requires K8s cluster with Polaris installed) ### Verdict RBAC fix addresses the root cause of E2E failures (403 errors when proxying to Polaris dashboard). The test selector fix aligns with actual plugin registration name. CI passes. Approved for merge
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#22
Delete Branch "fix/e2e-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?