privilegedescalation/headlamp-polaris-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 50 Wiki Activity

ci: install helm and kubectl in e2e workflow #35

Merged
ghost merged 1 commits from fix/e2e-workflow-tools into main 2026-03-11 02:05:53 +00:00
Conversation 2 Commits 1 Files Changed 1
+6
ghost commented 2026-03-10 23:54:10 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

The local-ubuntu-latest runner image does not contain helm and kubectl binaries, causing the E2E workflow to fail when it attempts to deploy Polaris and apply RBAC. This PR adds the azure/setup-helm and azure/setup-kubectl actions to ensure these tools are available before they are needed.

Addresses PRI-28.

## Summary The local-ubuntu-latest runner image does not contain `helm` and `kubectl` binaries, causing the E2E workflow to fail when it attempts to deploy Polaris and apply RBAC. This PR adds the `azure/setup-helm` and `azure/setup-kubectl` actions to ensure these tools are available before they are needed. Addresses PRI-28.
Chris Farhood reviewed 2026-03-11 00:48:52 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

Clean PR. Adds helm/kubectl setup and Polaris deployment to E2E workflow — exactly what's needed to unblock PRI-28. Uses official Azure setup actions. RBAC apply and readiness wait are correctly sequenced before Playwright install. Approved.

Clean PR. Adds helm/kubectl setup and Polaris deployment to E2E workflow — exactly what's needed to unblock PRI-28. Uses official Azure setup actions. RBAC apply and readiness wait are correctly sequenced before Playwright install. Approved.
Chris Farhood approved these changes 2026-03-11 01:50:27 +00:00
Chris Farhood left a comment
Copy Link
Copy Source

QA Review: Approved with notes.

What was tested

  • Ran test suite: pnpm test - 77 tests passed
  • Verified TypeScript: pnpm tsc - Pre-existing TS errors (not from this PR - same errors exist on main)
  • Reviewed diff for changes to workflow files, RBAC, package naming

Changes verified

  1. E2E workflow - Adds azure/setup-helm and azure/setup-kubectl actions
  2. Preflight checks - New step verifies Headlamp connectivity and plugin version
  3. RBAC - New deployment/polaris-rbac.yaml for service proxy access
  4. Package naming - Renamed from polaris to headlamp-polaris
  5. Workflow refactoring - Uses reusable workflows from .github repo

Notes

  • The pre-existing TS errors (vite-plugin-svgr/client, vite/client type definitions missing) exist on main - not a regression
  • Tests pass (77/77)
  • The PR addresses PRI-28 (E2E workflow missing helm/kubectl)

The PR is ready to merge once CI passes.

QA Review: Approved with notes. ## What was tested - Ran test suite: `pnpm test` - **77 tests passed** - Verified TypeScript: `pnpm tsc` - **Pre-existing TS errors** (not from this PR - same errors exist on main) - Reviewed diff for changes to workflow files, RBAC, package naming ## Changes verified 1. **E2E workflow** - Adds `azure/setup-helm` and `azure/setup-kubectl` actions 2. **Preflight checks** - New step verifies Headlamp connectivity and plugin version 3. **RBAC** - New `deployment/polaris-rbac.yaml` for service proxy access 4. **Package naming** - Renamed from `polaris` to `headlamp-polaris` 5. **Workflow refactoring** - Uses reusable workflows from `.github` repo ## Notes - The pre-existing TS errors (`vite-plugin-svgr/client`, `vite/client` type definitions missing) exist on main - not a regression - Tests pass (77/77) - The PR addresses PRI-28 (E2E workflow missing helm/kubectl) The PR is ready to merge once CI passes.
Sign in to join this conversation.
Reviewers
No Reviewers
Chris Farhood
Labels
Clear labels
P0
Must fix - blocking
 P0
Must fix - blocking
 bug
Something isn't working
 bug
Something isn't working
 cla:approved
cla:approved
confirmed
confirmed
documentation
Improvements or additions to documentation
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 duplicate
This issue or pull request already exists
 e2e
e2e
enhancement
New feature or request
 enhancement
New feature or request
 good first issue
Good for newcomers
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 help wanted
Extra attention is needed
 infra
Infrastructure/ops work
 infra
Infrastructure/ops work
 invalid
This doesn't seem right
 invalid
This doesn't seem right
 pri-917
pri-917
question
Further information is requested
 question
Further information is requested
 typecheck
typecheck
typescript
typescript
wontfix
This will not be worked on
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#35
Delete Branch "fix/e2e-workflow-tools"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?