fix: correct plugin settings registration name and add save button #4

Merged
cpfarhood merged 1 commits from fix/plugin-settings-registration into main 2026-02-12 03:40:46 +00:00
cpfarhood commented 2026-02-12 03:40:44 +00:00 (Migrated from github.com)

Summary

  • Fix plugin settings not showing by correcting registration name
  • Changed from 'polaris' to 'headlamp-polaris-plugin' (matches package.json)
  • Added displaySaveButton=true parameter

Root Cause

The plugin name passed to registerPluginSettings() must match the plugin name from package.json. We were using 'polaris' but the actual plugin name is 'headlamp-polaris-plugin'.

Changes

// Before
registerPluginSettings('polaris', PolarisSettings);

// After
registerPluginSettings('headlamp-polaris-plugin', PolarisSettings, true);

API Signature

According to Headlamp plugin API:

registerPluginSettings(name: string, component: PluginSettingsComponentType, displaySaveButton?: boolean): void

Test Plan

  • All tests passing (50/50)
  • TypeScript compilation clean
  • Build successful
  • 🎯 Settings page should now display with save button

🤖 Generated with Claude Code

## Summary - Fix plugin settings not showing by correcting registration name - Changed from `'polaris'` to `'headlamp-polaris-plugin'` (matches package.json) - Added `displaySaveButton=true` parameter ## Root Cause The plugin name passed to `registerPluginSettings()` must match the plugin name from `package.json`. We were using `'polaris'` but the actual plugin name is `'headlamp-polaris-plugin'`. ## Changes ```typescript // Before registerPluginSettings('polaris', PolarisSettings); // After registerPluginSettings('headlamp-polaris-plugin', PolarisSettings, true); ``` ## API Signature According to Headlamp plugin API: ```typescript registerPluginSettings(name: string, component: PluginSettingsComponentType, displaySaveButton?: boolean): void ``` ## Test Plan - ✅ All tests passing (50/50) - ✅ TypeScript compilation clean - ✅ Build successful - 🎯 Settings page should now display with save button 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#4