fix e2e: use button role for storage classes sidebar selector

The storage classes sidebar entry is rendered as a button, not a link. Fix the flaky E2E test by changing getByRole('link') to getByRole('button'). Fixes PRI-935 Co-Authored-By: Paperclip <noreply@paperclip.ing>
fix(e2e): write HEADLAMP_URL before token gen; add pods RBAC
2026-05-06 17:11:07 +00:00 · 2026-05-06 13:33:41 +00:00
2 changed files with 9 additions and 3 deletions
@@ -44,7 +44,7 @@ test.describe('Rook plugin smoke tests', () => {
    await page.goto('/c/main/rook-ceph');

    const sidebar = page.getByRole('navigation', { name: 'Navigation' });
-    const storageClassesLink = sidebar.getByRole('link', { name: /storage classes/i });
+    const storageClassesLink = sidebar.getByRole('button', { name: /storage classes/i });
    await expect(storageClassesLink).toBeVisible({ timeout: 10_000 });
    await storageClassesLink.click();

@@ -87,6 +87,9 @@ rules:
  - apiGroups: [""]
    resources: ["persistentvolumeclaims"]
    verbs: ["get", "list", "watch"]
+  - apiGroups: [""]
+    resources: ["pods"]
+    verbs: ["get", "list", "watch"]
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
@@ -216,15 +219,18 @@ done
 echo ""
 echo "E2E Headlamp is ready at: ${SVC_URL}"

+echo ""
+echo "Writing E2E env file..."
+echo "HEADLAMP_URL=${SVC_URL}" > "$REPO_ROOT/.env.e2e"
+
 echo ""
 echo "Creating service account token for E2E auth..."
 TOKEN=$(kubectl create token headlamp-e2e-test -n "$E2E_NAMESPACE" --duration=1h 2>/dev/null || echo "")
 if [ -n "$TOKEN" ]; then
-  echo "HEADLAMP_URL=${SVC_URL}" > "$REPO_ROOT/.env.e2e"
  echo "HEADLAMP_TOKEN=${TOKEN}" >> "$REPO_ROOT/.env.e2e"
  echo "Wrote .env.e2e with HEADLAMP_URL and HEADLAMP_TOKEN"
 else
-  echo "  WARNING: Could not generate token."
+  echo "Wrote .env.e2e with HEADLAMP_URL only (token generation failed, using OIDC fallback)"
 fi

 echo ""