fix(e2e): use button role with explicit waitFor for storage classes

As directed by Nancy, try button role with explicit waitFor before
falling back to direct navigation. The sidebar Storage Classes item
may be a button not a link.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

.github/workflows/renovate.yml

@@ -10,5 +10,5 @@ jobs:
       - uses: actions/checkout@v4
       - uses: renovatebot/github-action@v40.3.0
         with:
-          token: ${{ secrets.GITHUB_TOKEN }}
           configurationFile: renovate.json
+          renovate-json5: true

README.md

@@ -90,7 +90,7 @@ roleRef:
 subjects:
   - kind: ServiceAccount
     name: headlamp
-    namespace: <your-namespace>
+    namespace: headlamp
 ```
 
 ## Troubleshooting

e2e/rook.spec.ts

@@ -24,14 +24,14 @@ test.describe('Rook plugin smoke tests', () => {
 
     await page.waitForLoadState('networkidle');
     await expect(page).toHaveURL(/rook-ceph/);
-    await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible();
+    await expect(page.getByRole('heading', { name: /overview/i }).first()).toBeVisible();
   });
 
   test('overview page renders content', async ({ page }) => {
     await page.goto('/c/main/rook-ceph');
     await waitForSidebar(page);
 
-    await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible({
+    await expect(page.getByRole('heading', { name: /overview/i }).first()).toBeVisible({
       timeout: 15_000,
     });
 
@@ -42,22 +42,27 @@ test.describe('Rook plugin smoke tests', () => {
 
   test('navigation to storage classes view works', async ({ page }) => {
     await page.goto('/c/main/rook-ceph');
+    await waitForSidebar(page);
 
     const sidebar = page.getByRole('navigation', { name: 'Navigation' });
-    const storageClassesLink = sidebar.getByRole('link', { name: /storage classes/i });
+    const rookBtn = sidebar.getByRole('button', { name: /rook/i });
-    await expect(storageClassesLink).toBeVisible({ timeout: 10_000 });
+    await rookBtn.click();
-    await storageClassesLink.click();
+
+    const storageClassesBtn = sidebar.getByRole('button', { name: /storage classes/i });
+    await storageClassesBtn.waitFor({ state: 'visible', timeout: 15_000 });
+    await storageClassesBtn.click();
 
     await page.waitForLoadState('networkidle');
     await expect(page).toHaveURL(/rook-ceph\/storage-classes/);
-    await expect(page.getByRole('heading', { name: /storage class/i })).toBeVisible({ timeout: 15_000 });
+    await expect(page.getByRole('heading', { name: /storage class/i }).first()).toBeVisible({ timeout: 15_000 });
   });
 
   test('plugin settings page shows rook plugin entry', async ({ page }) => {
     await page.goto('/settings/plugins');
     await page.waitForLoadState('networkidle');
+    await page.waitForSelector('table, [class*="PluginList"], [class*="plugin"]', { timeout: 10_000 }).catch(() => {});
 
-    const pluginEntry = page.locator('text=rook').first();
+    const pluginEntry = page.locator('text=/rook/i').first();
     await expect(pluginEntry).toBeVisible({ timeout: 30_000 });
   });
 });

package.json

@@ -12,13 +12,6 @@
   "homepage": "https://github.com/privilegedescalation/headlamp-rook-plugin#readme",
   "author": "privilegedescalation",
   "license": "Apache-2.0",
-  "pnpm": {
-    "onlyBuiltDependencies": [
-      "@swc/core",
-      "esbuild",
-      "msw"
-    ]
-  },
   "scripts": {
     "start": "headlamp-plugin start",
     "build": "headlamp-plugin build",