fix(e2e): use button role with explicit waitFor for storage classes

As directed by Nancy, try button role with explicit waitFor before
falling back to direct navigation. The sidebar Storage Classes item
may be a button not a link.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

.github/workflows/e2e.yaml

@@ -16,9 +16,8 @@ concurrency:
 
 jobs:
   e2e:
-    uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@main
+    uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@hugh/add-pnpm-support-plugin-e2e
     with:
-      node-version: "22"
+      node-version: '22'
       headlamp-version: v0.40.1
       e2e-namespace: headlamp-dev
-      plugin-name: rook

.github/workflows/renovate.yml

@@ -0,0 +1,14 @@
+name: Renovate
+on:
+  schedule:
+    - cron: '0 3 * * *'
+  workflow_dispatch:
+jobs:
+  renovate:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: renovatebot/github-action@v40.3.0
+        with:
+          configurationFile: renovate.json
+          renovate-json5: true

e2e/rook.spec.ts

@@ -42,15 +42,15 @@ test.describe('Rook plugin smoke tests', () => {
 
   test('navigation to storage classes view works', async ({ page }) => {
     await page.goto('/c/main/rook-ceph');
-    const sidebar = page.getByRole('navigation', { name: 'Navigation' });
+    await waitForSidebar(page);
 
+    const sidebar = page.getByRole('navigation', { name: 'Navigation' });
     const rookBtn = sidebar.getByRole('button', { name: /rook/i });
     await rookBtn.click();
-    await page.waitForLoadState('networkidle');
 
-    const storageClassesLink = sidebar.getByRole('link', { name: /storage classes/i });
-    await expect(storageClassesLink).toBeVisible({ timeout: 10_000 });
-    await storageClassesLink.click();
+    const storageClassesBtn = sidebar.getByRole('button', { name: /storage classes/i });
+    await storageClassesBtn.waitFor({ state: 'visible', timeout: 15_000 });
+    await storageClassesBtn.click();
 
     await page.waitForLoadState('networkidle');
     await expect(page).toHaveURL(/rook-ceph\/storage-classes/);

package.json

@@ -50,6 +50,7 @@
     "tar": "^7.5.11",
     "undici": "^7.24.3",
     "vite": ">=6.4.2",
-    "lodash": ">=4.18.0"
+    "lodash": ">=4.18.0",
+    "elliptic": ">=6.6.1"
   }
 }

scripts/deploy-e2e-headlamp.sh

@@ -35,17 +35,6 @@ if ! kubectl auth can-i delete configmaps -n "$E2E_NAMESPACE" --quiet 2>/dev/nul
   exit 1
 fi
 
-echo ""
-echo "=== Pre-deployment cluster diagnostics ==="
-echo "Nodes:"
-kubectl get nodes -o wide 2>&1 || true
-echo ""
-echo "headlamp-dev namespace state:"
-kubectl get ns headlamp-dev -o yaml 2>&1 || true
-echo ""
-echo "Existing E2E resources in namespace:"
-kubectl get all -n "$E2E_NAMESPACE" -l "app.kubernetes.io/instance=$E2E_RELEASE" 2>&1 || true
-
 echo "=== E2E Headlamp Deployment ==="
 echo "  Image:     ghcr.io/headlamp-k8s/headlamp:${HEADLAMP_VERSION}"
 echo "  Namespace: $E2E_NAMESPACE"
@@ -71,7 +60,7 @@ kubectl delete serviceaccount "${E2E_RELEASE}" -n "$E2E_NAMESPACE" --ignore-not-
 echo ""
 echo "Deploying Headlamp E2E instance..."
 
-if ! kubectl apply -f - <<EOF
+kubectl apply -f - <<EOF
 apiVersion: v1
 kind: ServiceAccount
 metadata:
@@ -124,7 +113,7 @@ spec:
               port: http
             initialDelaySeconds: 5
             periodSeconds: 5
-              failureThreshold: 6
+            failureThreshold: 6
           livenessProbe:
             httpGet:
               path: /
@@ -159,12 +148,6 @@ spec:
       targetPort: http
       protocol: TCP
 EOF
-then
-  echo "ERROR: kubectl apply failed. Dumping cluster state..." >&2
-  kubectl get all -n "$E2E_NAMESPACE" 2>&1 || true
-  kubectl get events -n "$E2E_NAMESPACE" --sort-by='.lastTimestamp' 2>&1 | tail -30 || true
-  exit 1
-fi
 
 echo "Waiting for rollout..."
 kubectl rollout status "deployment/${E2E_RELEASE}" \