Compare commits

..

2 Commits

Author SHA1 Message Date
Chris Farhood ac8c2499a2 fix(e2e): reference @main workflow after .github merge
Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-05 17:43:52 +00:00
Chris Farhood 13347ab9c1 fix(e2e): prevent stale sidebar reference in storage-classes navigation test
Re-acquire sidebar reference after clicking Rook button to avoid
stale locator capturing wrong sidebar state during transition.

PR #56 follow-up for PRI-699.
2026-05-05 14:02:34 +00:00
3 changed files with 8 additions and 22 deletions
-1
View File
@@ -21,4 +21,3 @@ jobs:
node-version: "22"
headlamp-version: v0.40.1
e2e-namespace: headlamp-dev
plugin-name: rook
+6 -2
View File
@@ -45,11 +45,15 @@ test.describe('Rook plugin smoke tests', () => {
const sidebar = page.getByRole('navigation', { name: 'Navigation' });
const rookBtn = sidebar.getByRole('button', { name: /rook/i });
await expect(rookBtn).toBeVisible();
await rookBtn.click();
await page.waitForLoadState('networkidle');
const storageClassesLink = sidebar.getByRole('link', { name: /storage classes/i });
await expect(storageClassesLink).toBeVisible({ timeout: 10_000 });
const sidebarAfterClick = page.getByRole('navigation', { name: 'Navigation' });
await expect(sidebarAfterClick).toBeVisible();
const storageClassesLink = sidebarAfterClick.getByRole('link', { name: /storage classes/i });
await storageClassesLink.waitFor({ state: 'visible', timeout: 15_000 });
await storageClassesLink.click();
await page.waitForLoadState('networkidle');
+2 -19
View File
@@ -35,17 +35,6 @@ if ! kubectl auth can-i delete configmaps -n "$E2E_NAMESPACE" --quiet 2>/dev/nul
exit 1
fi
echo ""
echo "=== Pre-deployment cluster diagnostics ==="
echo "Nodes:"
kubectl get nodes -o wide 2>&1 || true
echo ""
echo "headlamp-dev namespace state:"
kubectl get ns headlamp-dev -o yaml 2>&1 || true
echo ""
echo "Existing E2E resources in namespace:"
kubectl get all -n "$E2E_NAMESPACE" -l "app.kubernetes.io/instance=$E2E_RELEASE" 2>&1 || true
echo "=== E2E Headlamp Deployment ==="
echo " Image: ghcr.io/headlamp-k8s/headlamp:${HEADLAMP_VERSION}"
echo " Namespace: $E2E_NAMESPACE"
@@ -71,7 +60,7 @@ kubectl delete serviceaccount "${E2E_RELEASE}" -n "$E2E_NAMESPACE" --ignore-not-
echo ""
echo "Deploying Headlamp E2E instance..."
if ! kubectl apply -f - <<EOF
kubectl apply -f - <<EOF
apiVersion: v1
kind: ServiceAccount
metadata:
@@ -124,7 +113,7 @@ spec:
port: http
initialDelaySeconds: 5
periodSeconds: 5
failureThreshold: 6
failureThreshold: 6
livenessProbe:
httpGet:
path: /
@@ -159,12 +148,6 @@ spec:
targetPort: http
protocol: TCP
EOF
then
echo "ERROR: kubectl apply failed. Dumping cluster state..." >&2
kubectl get all -n "$E2E_NAMESPACE" 2>&1 || true
kubectl get events -n "$E2E_NAMESPACE" --sort-by='.lastTimestamp' 2>&1 | tail -30 || true
exit 1
fi
echo "Waiting for rollout..."
kubectl rollout status "deployment/${E2E_RELEASE}" \