fix(e2e): reference @main workflow after .github merge

Co-Authored-By: Paperclip <noreply@paperclip.ing>
fix(e2e): prevent stale sidebar reference in storage-classes navigation test
2026-05-05 17:43:52 +00:00 · 2026-05-05 14:02:34 +00:00 · 2026-05-05 13:56:35 +00:00 · 2026-05-05 13:04:45 +00:00 · 2026-05-05 12:21:22 +00:00
2 changed files with 18 additions and 9 deletions
@@ -16,8 +16,8 @@ concurrency:

 jobs:
  e2e:
-    uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@hugh/add-pnpm-support-plugin-e2e
+    uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@main
    with:
-      node-version: '22'
+      node-version: "22"
      headlamp-version: v0.40.1
      e2e-namespace: headlamp-dev
@@ -24,14 +24,14 @@ test.describe('Rook plugin smoke tests', () => {

    await page.waitForLoadState('networkidle');
    await expect(page).toHaveURL(/rook-ceph/);
-    await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible();
+    await expect(page.getByRole('heading', { name: /overview/i }).first()).toBeVisible();
  });

  test('overview page renders content', async ({ page }) => {
    await page.goto('/c/main/rook-ceph');
    await waitForSidebar(page);

-    await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible({
+    await expect(page.getByRole('heading', { name: /overview/i }).first()).toBeVisible({
      timeout: 15_000,
    });

@@ -42,22 +42,31 @@ test.describe('Rook plugin smoke tests', () => {

  test('navigation to storage classes view works', async ({ page }) => {
    await page.goto('/c/main/rook-ceph');
-
    const sidebar = page.getByRole('navigation', { name: 'Navigation' });
-    const storageClassesLink = sidebar.getByRole('link', { name: /storage classes/i });
-    await expect(storageClassesLink).toBeVisible({ timeout: 10_000 });
+
+    const rookBtn = sidebar.getByRole('button', { name: /rook/i });
+    await expect(rookBtn).toBeVisible();
+    await rookBtn.click();
+    await page.waitForLoadState('networkidle');
+
+    const sidebarAfterClick = page.getByRole('navigation', { name: 'Navigation' });
+    await expect(sidebarAfterClick).toBeVisible();
+
+    const storageClassesLink = sidebarAfterClick.getByRole('link', { name: /storage classes/i });
+    await storageClassesLink.waitFor({ state: 'visible', timeout: 15_000 });
    await storageClassesLink.click();

    await page.waitForLoadState('networkidle');
    await expect(page).toHaveURL(/rook-ceph\/storage-classes/);
-    await expect(page.getByRole('heading', { name: /storage class/i })).toBeVisible({ timeout: 15_000 });
+    await expect(page.getByRole('heading', { name: /storage class/i }).first()).toBeVisible({ timeout: 15_000 });
  });

  test('plugin settings page shows rook plugin entry', async ({ page }) => {
    await page.goto('/settings/plugins');
    await page.waitForLoadState('networkidle');
+    await page.waitForSelector('table, [class*="PluginList"], [class*="plugin"]', { timeout: 10_000 }).catch(() => {});

-    const pluginEntry = page.locator('text=rook').first();
+    const pluginEntry = page.locator('text=/rook/i').first();
    await expect(pluginEntry).toBeVisible({ timeout: 30_000 });
  });
 });
Author	SHA1	Message	Date
Chris Farhood	ac8c2499a2	fix(e2e): reference @main workflow after .github merge Co-Authored-By: Paperclip <noreply@paperclip.ing>	2026-05-05 17:43:52 +00:00
Chris Farhood	13347ab9c1	fix(e2e): prevent stale sidebar reference in storage-classes navigation test Re-acquire sidebar reference after clicking Rook button to avoid stale locator capturing wrong sidebar state during transition. PR #56 follow-up for PRI-699.	2026-05-05 14:02:34 +00:00
Chris Farhood	0d9f9d859a	fix(e2e): use .first() to handle strict mode violations (PRI-699) Similar to the kube-vip fix, /overview/i and /storage class/i can match multiple headings. Using .first() to avoid strict mode violations.	2026-05-05 13:56:35 +00:00
Chris Farhood	61df61c691	fix(e2e): expand storage classes sidebar nav and relax plugin settings locator The 'Storage Classes' link is nested under the Rook sidebar button, not at the top level. Expand the Rook section before asserting visibility. Also uses /rook/i case-insensitive regex and waits for the plugins list to render before searching.	2026-05-05 13:04:45 +00:00
Chris Farhood	15d161c312	fix(e2e): use pnpm-capable workflow branch with namespace param	2026-05-05 12:21:22 +00:00