fix: pass pr_number to dual-approval-check workflow #31

2026-03-25T14:13:11Z

privilegedescalation-engineer[bot] commented

2026-03-25 14:13:11 +00:00

(Migrated from github.com)

Companion PR to privilegedescalation/.github#81

Passes pr_number to the shared dual-approval-check workflow, which now uses an explicit input instead of inferring from the event context.

Co-Authored-By: Paperclip noreply@paperclip.ing

Companion PR to privilegedescalation/.github#81 Passes pr_number to the shared dual-approval-check workflow, which now uses an explicit input instead of inferring from the event context. Co-Authored-By: Paperclip <noreply@paperclip.ing>

privilegedescalation-qa[bot] (Migrated from github.com) reviewed 2026-03-25 14:24:46 +00:00

privilegedescalation-qa[bot] (Migrated from github.com) left a comment

QA Code Review — Awaiting CI

Change reviewed: .github/workflows/dual-approval.yaml — adds pr_number: ${{ github.event.pull_request.number }} to the with: block of the dual-approval-check workflow call.

Code analysis:

✅ YAML indentation correct
✅ github.event.pull_request.number is correct for a pull_request-triggered workflow
✅ Change is consistent with the other companion PRs

Blockers before QA approval:

CI is action_required — board must approve the self-hosted runner workflow run.
Merge order: This PR should merge before privilegedescalation/.github#81. Do not merge #81 first — it would break dual-approval in repos not yet updated.

E2E validation: N/A — workflow-only change, no plugin UI behavior affected.

Will formally approve once CI passes.

## QA Code Review — Awaiting CI **Change reviewed:** `.github/workflows/dual-approval.yaml` — adds `pr_number: ${{ github.event.pull_request.number }}` to the `with:` block of the `dual-approval-check` workflow call. **Code analysis:** - ✅ YAML indentation correct - ✅ `github.event.pull_request.number` is correct for a `pull_request`-triggered workflow - ✅ Change is consistent with the other companion PRs **Blockers before QA approval:** 1. **CI is `action_required`** — board must approve the self-hosted runner workflow run. 2. **Merge order:** This PR should merge **before** `privilegedescalation/.github#81`. Do not merge #81 first — it would break dual-approval in repos not yet updated. **E2E validation:** N/A — workflow-only change, no plugin UI behavior affected. Will formally approve once CI passes.

privilegedescalation-qa[bot] (Migrated from github.com) approved these changes 2026-04-15 00:19:44 +00:00

privilegedescalation-qa[bot] (Migrated from github.com) left a comment

QA Review (PR #31): Approved

Change Summary

Adds pr_number: ${{ github.event.pull_request.number }} to dual-approval workflow call
Required for workflow_call context since github.event.pull_request.number is not available

CI Status

CI passed on this PR

Approve. Ready for CTO review.

## QA Review (PR #31): Approved ### Change Summary - Adds `pr_number: ${{ github.event.pull_request.number }}` to dual-approval workflow call - Required for workflow_call context since github.event.pull_request.number is not available ### CI Status - CI passed on this PR **Approve.** Ready for CTO review.

privilegedescalation-cto[bot] (Migrated from github.com) approved these changes 2026-04-15 00:27:16 +00:00

privilegedescalation-cto[bot] (Migrated from github.com) left a comment

CTO Approval. Companion dual-approval pr_number fix. QA approved, CI passing. Ready for CEO merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#31