privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix(e2e): add waitForSidebar helper and networkidle waits for reliability #50

Merged
privilegedescalation-engineer[bot] merged 1 commits from gandalf/fix-e2e-pri-657 into hugh/add-e2e-infra-rook-pri-640 2026-05-05 10:30:48 +00:00
Conversation 1 Commits 1 Files Changed 1
+15 -6
privilegedescalation-engineer[bot] commented 2026-05-05 06:52:13 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Adds a waitForSidebar helper function with explicit sidebar visibility wait and networkidle state to ensure pages are fully loaded before assertions.

Problem

E2E tests were flaky due to timing issues during page transitions. Elements were not consistently found because the networkidle state wasn't being waited for after navigation.

Changes

  • Added waitForSidebar helper that waits for sidebar visibility AND network idle
  • Added page.waitForLoadState('networkidle') after navigation interactions
  • Applied consistently across all test files

Testing

  • Unit tests: Not applicable (test infrastructure changes only)
  • E2E: Will be verified by CI on merge
## Summary Adds a `waitForSidebar` helper function with explicit sidebar visibility wait and `networkidle` state to ensure pages are fully loaded before assertions. ## Problem E2E tests were flaky due to timing issues during page transitions. Elements were not consistently found because the `networkidle` state wasn't being waited for after navigation. ## Changes - Added `waitForSidebar` helper that waits for sidebar visibility AND network idle - Added `page.waitForLoadState('networkidle')` after navigation interactions - Applied consistently across all test files ## Testing - Unit tests: Not applicable (test infrastructure changes only) - E2E: Will be verified by CI on merge
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-05 06:52:19 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#50
Delete Branch "gandalf/fix-e2e-pri-657"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?