privilegedescalation/headlamp-rook-plugin
Archived
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix(e2e): stale sidebar locator in storage-classes test (PRI-699) #57

Closed
privilegedescalation-engineer[bot] wants to merge 5 commits from gandalf/fix-flaky-storage-class into main
pull from: gandalf/fix-flaky-storage-class
merge into: privilegedescalation:main
Conversation 3 Commits 5 Files Changed 2
+18 -9
2 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/e2e.yaml
+2 -2
View File
@@ -16,8 +16,8 @@ concurrency:
jobs: jobs:
e2e: e2e:
uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@hugh/add-pnpm-support-plugin-e2e uses: privilegedescalation/.github/.github/workflows/plugin-e2e.yaml@main
with: with:
node-version: '22' node-version: "22"
headlamp-version: v0.40.1 headlamp-version: v0.40.1
e2e-namespace: headlamp-dev e2e-namespace: headlamp-dev
e2e/rook.spec.ts
+16 -7
View File
@@ -24,14 +24,14 @@ test.describe('Rook plugin smoke tests', () => {
await page.waitForLoadState('networkidle'); await page.waitForLoadState('networkidle');
await expect(page).toHaveURL(/rook-ceph/); await expect(page).toHaveURL(/rook-ceph/);
await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible(); await expect(page.getByRole('heading', { name: /overview/i }).first()).toBeVisible();
}); });
test('overview page renders content', async ({ page }) => { test('overview page renders content', async ({ page }) => {
await page.goto('/c/main/rook-ceph'); await page.goto('/c/main/rook-ceph');
await waitForSidebar(page); await waitForSidebar(page);
await expect(page.getByRole('heading', { name: /overview/i })).toBeVisible({ await expect(page.getByRole('heading', { name: /overview/i }).first()).toBeVisible({
timeout: 15_000, timeout: 15_000,
}); });
@@ -42,22 +42,31 @@ test.describe('Rook plugin smoke tests', () => {
test('navigation to storage classes view works', async ({ page }) => { test('navigation to storage classes view works', async ({ page }) => {
await page.goto('/c/main/rook-ceph'); await page.goto('/c/main/rook-ceph');
const sidebar = page.getByRole('navigation', { name: 'Navigation' }); const sidebar = page.getByRole('navigation', { name: 'Navigation' });
const storageClassesLink = sidebar.getByRole('link', { name: /storage classes/i });
await expect(storageClassesLink).toBeVisible({ timeout: 10_000 }); const rookBtn = sidebar.getByRole('button', { name: /rook/i });
await expect(rookBtn).toBeVisible();
await rookBtn.click();
await page.waitForLoadState('networkidle');
const sidebarAfterClick = page.getByRole('navigation', { name: 'Navigation' });
await expect(sidebarAfterClick).toBeVisible();
const storageClassesLink = sidebarAfterClick.getByRole('link', { name: /storage classes/i });
await storageClassesLink.waitFor({ state: 'visible', timeout: 15_000 });
await storageClassesLink.click(); await storageClassesLink.click();
await page.waitForLoadState('networkidle'); await page.waitForLoadState('networkidle');
await expect(page).toHaveURL(/rook-ceph\/storage-classes/); await expect(page).toHaveURL(/rook-ceph\/storage-classes/);
await expect(page.getByRole('heading', { name: /storage class/i })).toBeVisible({ timeout: 15_000 }); await expect(page.getByRole('heading', { name: /storage class/i }).first()).toBeVisible({ timeout: 15_000 });
}); });
test('plugin settings page shows rook plugin entry', async ({ page }) => { test('plugin settings page shows rook plugin entry', async ({ page }) => {
await page.goto('/settings/plugins'); await page.goto('/settings/plugins');
await page.waitForLoadState('networkidle'); await page.waitForLoadState('networkidle');
await page.waitForSelector('table, [class*="PluginList"], [class*="plugin"]', { timeout: 10_000 }).catch(() => {});
const pluginEntry = page.locator('text=rook').first(); const pluginEntry = page.locator('text=/rook/i').first();
await expect(pluginEntry).toBeVisible({ timeout: 30_000 }); await expect(pluginEntry).toBeVisible({ timeout: 30_000 });
}); });
}); });