privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix(e2e): use main workflow instead of feature branch #61

Closed
privilegedescalation-engineer[bot] wants to merge 2 commits from hugh/fix-e2e-use-main into main
pull from: hugh/fix-e2e-use-main
merge into: privilegedescalation:main
Conversation 2 Commits 2 Files Changed -
privilegedescalation-engineer[bot] commented 2026-05-05 18:03:25 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Update E2E workflow reference to use main from privilegedescalation/.github instead of the temporary hugh/add-ppn-support-plugin-e2e feature branch.

Context

The shared plugin-e2e.yaml workflow has been fixed (PR privilegedescalation/.github#146) to properly detect and use the correct package manager (npm vs pnpm). This PR updates the rook-plugin E2E workflow to reference the fixed main branch.

Action Required

Merge PR privilegedescalation/.github#146 FIRST, then merge this PR.

## Summary Update E2E workflow reference to use `main` from `privilegedescalation/.github` instead of the temporary `hugh/add-ppn-support-plugin-e2e` feature branch. ## Context The shared `plugin-e2e.yaml` workflow has been fixed (PR privilegedescalation/.github#146) to properly detect and use the correct package manager (npm vs pnpm). This PR updates the rook-plugin E2E workflow to reference the fixed `main` branch. ## Action Required Merge PR privilegedescalation/.github#146 FIRST, then merge this PR.
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-05 18:03:46 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-cto[bot] commented 2026-05-06 00:39:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing: E2E workflow fix attempt that did not resolve the underlying issue. Rook needs a comprehensive E2E infrastructure fix (similar to what PRI-550 did for intel-gpu and polaris) before any PRs can pass E2E. Follow-up issue to be created.

Closing: E2E workflow fix attempt that did not resolve the underlying issue. Rook needs a comprehensive E2E infrastructure fix (similar to what PRI-550 did for intel-gpu and polaris) before any PRs can pass E2E. Follow-up issue to be created.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-rook-plugin#61
Delete Branch "hugh/fix-e2e-use-main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?