fix: move node-forge to devDependencies for proper bundling

Moving node-forge from dependencies to devDependencies ensures it gets
bundled into the plugin instead of being externalized. This is required
because Headlamp doesn't provide node-forge as a shared library.

The .pluginrc file with empty externals forces bundling of all deps,
and keeping node-forge in devDependencies makes this behavior explicit.

This fixes the frontend loading error:
"TypeError: undefined is not an object (evaluating 'Ot.KubeObject')"

Changes:
- Moved node-forge from dependencies to devDependencies
- Updated package-lock.json to mark node-forge as dev dependency
- .pluginrc remains in place to enforce bundling

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
This commit is contained in:
2026-02-12 17:40:50 -05:00
parent 9802448e82
commit 37391cd92a
2 changed files with 5 additions and 8 deletions
+4 -5
View File
@@ -1,20 +1,18 @@
{ {
"name": "headlamp-sealed-secrets", "name": "headlamp-sealed-secrets",
"version": "0.2.2", "version": "0.2.5",
"lockfileVersion": 3, "lockfileVersion": 3,
"requires": true, "requires": true,
"packages": { "packages": {
"": { "": {
"name": "headlamp-sealed-secrets", "name": "headlamp-sealed-secrets",
"version": "0.2.2", "version": "0.2.5",
"license": "Apache-2.0", "license": "Apache-2.0",
"dependencies": {
"node-forge": "^1.3.1"
},
"devDependencies": { "devDependencies": {
"@iconify/react": "^6.0.2", "@iconify/react": "^6.0.2",
"@kinvolk/headlamp-plugin": "^0.13.0", "@kinvolk/headlamp-plugin": "^0.13.0",
"@types/node-forge": "^1.3.11", "@types/node-forge": "^1.3.11",
"node-forge": "^1.3.1",
"typedoc": "^0.28.16", "typedoc": "^0.28.16",
"typedoc-plugin-markdown": "^4.10.0" "typedoc-plugin-markdown": "^4.10.0"
} }
@@ -12399,6 +12397,7 @@
"version": "1.3.3", "version": "1.3.3",
"resolved": "https://registry.npmjs.org/node-forge/-/node-forge-1.3.3.tgz", "resolved": "https://registry.npmjs.org/node-forge/-/node-forge-1.3.3.tgz",
"integrity": "sha512-rLvcdSyRCyouf6jcOIPe/BgwG/d7hKjzMKOas33/pHEr6gbq18IK9zV7DiPvzsz0oBJPme6qr6H6kGZuI9/DZg==", "integrity": "sha512-rLvcdSyRCyouf6jcOIPe/BgwG/d7hKjzMKOas33/pHEr6gbq18IK9zV7DiPvzsz0oBJPme6qr6H6kGZuI9/DZg==",
"dev": true,
"license": "(BSD-3-Clause OR GPL-2.0)", "license": "(BSD-3-Clause OR GPL-2.0)",
"engines": { "engines": {
"node": ">= 6.13.0" "node": ">= 6.13.0"
+1 -3
View File
@@ -56,13 +56,11 @@
"overrides": { "overrides": {
"typescript": "5.6.2" "typescript": "5.6.2"
}, },
"dependencies": {
"node-forge": "^1.3.1"
},
"devDependencies": { "devDependencies": {
"@iconify/react": "^6.0.2", "@iconify/react": "^6.0.2",
"@kinvolk/headlamp-plugin": "^0.13.0", "@kinvolk/headlamp-plugin": "^0.13.0",
"@types/node-forge": "^1.3.11", "@types/node-forge": "^1.3.11",
"node-forge": "^1.3.1",
"typedoc": "^0.28.16", "typedoc": "^0.28.16",
"typedoc-plugin-markdown": "^4.10.0" "typedoc-plugin-markdown": "^4.10.0"
} }