fix: enable drawer scrolling, fix blank settings page, and eliminate retry button requirement

- Add overflow: auto to drawer Box wrapper for vertical scrolling
- Remove unnecessary SectionBox wrapper from SettingsPage (Headlamp provides container)
- Add param guard to prevent race condition on initial detail view load

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
This commit is contained in:
2026-02-13 07:38:24 -05:00
parent 889504962d
commit 5cf360b591
2 changed files with 7 additions and 7 deletions
@@ -74,6 +74,11 @@ export function SealedSecretDetail() {
}
}, [namespace]);
// Wait for required params before rendering
if (!namespace || !name) {
return <SealedSecretDetailSkeleton />;
}
// Show error if fetch failed
if (error) {
return (
@@ -146,7 +151,7 @@ export function SealedSecretDetail() {
},
}}
>
<Box>
<Box sx={{ height: '100%', overflow: 'auto' }}>
<SectionBox
title={
<Box display="flex" alignItems="center" justifyContent="space-between">
@@ -4,7 +4,6 @@
* Configuration page for the Sealed Secrets plugin
*/
import { SectionBox } from '@kinvolk/headlamp-plugin/lib/CommonComponents';
import { Box, Button, Divider, TextField, Typography } from '@mui/material';
import { useSnackbar } from 'notistack';
import React from 'react';
@@ -35,10 +34,7 @@ export function SettingsPage() {
};
return (
<SectionBox
title="Sealed Secrets Plugin Settings"
>
<Box p={3}>
<Box p={3}>
<Typography variant="body1" paragraph id="settings-description">
Configure the connection to your Sealed Secrets controller. These settings are stored in
your browser's local storage.
@@ -156,6 +152,5 @@ export function SettingsPage() {
</Typography>
</Box>
</Box>
</SectionBox>
);
}