fix: enable drawer scrolling, fix blank settings page, and eliminate retry button requirement
- Add overflow: auto to drawer Box wrapper for vertical scrolling - Remove unnecessary SectionBox wrapper from SettingsPage (Headlamp provides container) - Add param guard to prevent race condition on initial detail view load Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This commit is contained in:
@@ -74,6 +74,11 @@ export function SealedSecretDetail() {
|
|||||||
}
|
}
|
||||||
}, [namespace]);
|
}, [namespace]);
|
||||||
|
|
||||||
|
// Wait for required params before rendering
|
||||||
|
if (!namespace || !name) {
|
||||||
|
return <SealedSecretDetailSkeleton />;
|
||||||
|
}
|
||||||
|
|
||||||
// Show error if fetch failed
|
// Show error if fetch failed
|
||||||
if (error) {
|
if (error) {
|
||||||
return (
|
return (
|
||||||
@@ -146,7 +151,7 @@ export function SealedSecretDetail() {
|
|||||||
},
|
},
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
<Box>
|
<Box sx={{ height: '100%', overflow: 'auto' }}>
|
||||||
<SectionBox
|
<SectionBox
|
||||||
title={
|
title={
|
||||||
<Box display="flex" alignItems="center" justifyContent="space-between">
|
<Box display="flex" alignItems="center" justifyContent="space-between">
|
||||||
|
|||||||
@@ -4,7 +4,6 @@
|
|||||||
* Configuration page for the Sealed Secrets plugin
|
* Configuration page for the Sealed Secrets plugin
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { SectionBox } from '@kinvolk/headlamp-plugin/lib/CommonComponents';
|
|
||||||
import { Box, Button, Divider, TextField, Typography } from '@mui/material';
|
import { Box, Button, Divider, TextField, Typography } from '@mui/material';
|
||||||
import { useSnackbar } from 'notistack';
|
import { useSnackbar } from 'notistack';
|
||||||
import React from 'react';
|
import React from 'react';
|
||||||
@@ -35,10 +34,7 @@ export function SettingsPage() {
|
|||||||
};
|
};
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<SectionBox
|
<Box p={3}>
|
||||||
title="Sealed Secrets Plugin Settings"
|
|
||||||
>
|
|
||||||
<Box p={3}>
|
|
||||||
<Typography variant="body1" paragraph id="settings-description">
|
<Typography variant="body1" paragraph id="settings-description">
|
||||||
Configure the connection to your Sealed Secrets controller. These settings are stored in
|
Configure the connection to your Sealed Secrets controller. These settings are stored in
|
||||||
your browser's local storage.
|
your browser's local storage.
|
||||||
@@ -156,6 +152,5 @@ export function SettingsPage() {
|
|||||||
</Typography>
|
</Typography>
|
||||||
</Box>
|
</Box>
|
||||||
</Box>
|
</Box>
|
||||||
</SectionBox>
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user