Compare commits

...

4 Commits

Author SHA1 Message Date
Chris Farhood 584c1226c8 fix(e2e): remove invalid inputs from reusable workflow call
The plugin-e2e.yaml reusable workflow only accepts node-version and
headlamp-version inputs. Remove e2e-namespace and plugin-name which
are not defined and causing startup_failure.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-06 16:55:33 +00:00
Chris Farhood c5b8eb5c92 fix(e2e): add missing plugin-name input in e2e.yaml (PRI-910)
Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-06 16:21:35 +00:00
Chris Farhood 1d506a0149 fix(e2e): use .first() to handle strict mode violations (PRI-701)
Strict mode violations:
- /sealed.secrets/i matches both 'Sealed Secrets' and 'All Sealed Secrets' buttons
- /sealing.key/i may match multiple headings

Using .first() for heading assertions to avoid strict mode.
2026-05-06 16:11:55 +00:00
Chris Farhood 8798cd1709 fix(e2e): add waitForSidebar and networkidle waits + fix nav test (PRI-701)
- Adds waitForSidebar helper with sidebar visibility wait + networkidle
- Fixes 'navigation between sealed-secrets views' to use waitForSidebar and expand sidebar before nav
- Plugin settings test waits for list before searching
2026-05-06 16:11:55 +00:00
2 changed files with 26 additions and 16 deletions
-1
View File
@@ -20,4 +20,3 @@ jobs:
with:
node-version: "22"
headlamp-version: v0.40.1
e2e-namespace: headlamp-dev
+26 -15
View File
@@ -1,34 +1,40 @@
import { test, expect } from '@playwright/test';
async function waitForSidebar(page: import('@playwright/test').Page) {
const sidebar = page.getByRole('navigation', { name: 'Navigation' });
await expect(sidebar).toBeVisible({ timeout: 15_000 });
await page.waitForLoadState('networkidle');
return sidebar;
}
test.describe('Sealed Secrets plugin smoke tests', () => {
test('sidebar contains sealed-secrets entry', async ({ page }) => {
await page.goto('/');
const sidebar = page.getByRole('navigation', { name: 'Navigation' });
await expect(sidebar).toBeVisible({ timeout: 15_000 });
const sidebar = await waitForSidebar(page);
await expect(sidebar.getByRole('button', { name: /sealed.secrets/i })).toBeVisible();
});
test('sidebar sealed-secrets entry is clickable and navigates to list view', async ({ page }) => {
await page.goto('/');
const sidebar = page.getByRole('navigation', { name: 'Navigation' });
await expect(sidebar).toBeVisible({ timeout: 15_000 });
const sidebar = await waitForSidebar(page);
const sealedSecretsEntry = sidebar.getByRole('button', { name: /sealed.secrets/i });
await expect(sealedSecretsEntry).toBeVisible();
await sealedSecretsEntry.click();
await page.waitForLoadState('networkidle');
await expect(page).toHaveURL(/\/sealedsecrets/);
await expect(page.getByRole('heading', { name: /sealed.secrets/i })).toBeVisible();
});
test('sealed secrets list page renders table or empty state', async ({ page }) => {
await page.goto('/c/main/sealedsecrets');
await waitForSidebar(page);
await expect(page.getByRole('heading', { name: /sealed.secrets/i })).toBeVisible({
timeout: 15_000,
});
// Either a populated table or an empty-state indicator must be visible
const hasTable = await page.locator('table').first().isVisible().catch(() => false);
const hasEmptyState = await page
.locator('text=/no.*sealed|no.*secret|0 item|empty/i')
@@ -40,6 +46,7 @@ test.describe('Sealed Secrets plugin smoke tests', () => {
test('sealing keys page renders table or empty state', async ({ page }) => {
await page.goto('/c/main/sealedsecrets/keys');
await waitForSidebar(page);
await expect(page.getByRole('heading', { name: /sealing.key/i })).toBeVisible({
timeout: 15_000,
@@ -56,33 +63,37 @@ test.describe('Sealed Secrets plugin smoke tests', () => {
test('navigation between sealed-secrets views works', async ({ page }) => {
await page.goto('/c/main/sealedsecrets');
await expect(page.getByRole('heading', { name: /sealed.secrets/i })).toBeVisible({
timeout: 15_000,
});
const sidebar = await waitForSidebar(page);
const sealedBtn = sidebar.getByRole('button', { name: /sealed.secrets/i }).first();
await sealedBtn.click();
await page.waitForLoadState('networkidle');
await expect(page.getByRole('heading', { name: /sealed.secrets/i }).first()).toBeVisible({ timeout: 15_000 });
// Navigate to Sealing Keys via sidebar
const sidebar = page.getByRole('navigation', { name: 'Navigation' });
const keysLink = sidebar.getByRole('link', { name: /sealing.key/i });
await expect(keysLink).toBeVisible();
await keysLink.click();
await page.waitForLoadState('networkidle');
await expect(page).toHaveURL(/\/sealedsecrets\/keys$/);
await expect(page.getByRole('heading', { name: /sealing.key/i })).toBeVisible();
await expect(page.getByRole('heading', { name: /sealing.key/i }).first()).toBeVisible();
// Navigate back to All Sealed Secrets
const allSecretsLink = sidebar.getByRole('link', { name: /all sealed secrets/i });
await expect(allSecretsLink).toBeVisible();
await allSecretsLink.click();
await page.waitForLoadState('networkidle');
await expect(page).toHaveURL(/\/sealedsecrets(?!\/keys)/);
await expect(page.getByRole('heading', { name: /sealed.secrets/i })).toBeVisible();
await expect(page.getByRole('heading', { name: /sealed.secrets/i }).first()).toBeVisible();
});
test('plugin settings page shows sealed-secrets plugin entry', async ({ page }) => {
await page.goto('/settings/plugins');
await page.waitForLoadState('networkidle');
await page.waitForSelector('table', { timeout: 10_000 }).catch(() => {});
// Wait for plugin list to load — plugin scripts load asynchronously
const pluginEntry = page.locator('text=sealed-secrets').first();
const pluginEntry = page.locator('text=/sealed.secrets/i').first();
await expect(pluginEntry).toBeVisible({ timeout: 30_000 });
});
});