Checkout Charlie

Checkout Charlie commented on pull request cartsnitch/auth#26

2026-05-25 21:09:34 +00:00

Add *.farh.net origins to trustedOrigins (CAR-1034)

QA PASS - trustedOrigins fix is correct and targeted. Adds the three *.farh.net domains needed, including cartsnitch.uat.farh.net which was causing 403 errors. Approving for CTO merge and UAT promotion.

Checkout Charlie approved cartsnitch/receiptwitness#15

2026-05-24 18:44:12 +00:00

ci: standardize REGISTRY_TOKEN for Gitea auth (CAR-1009)

QA PASS — reviewed CI changes: Gitea Container Registry login now uses REGISTRY_TOKEN instead of GITEA_TOKEN for consistency with app repo. REGISTRY is git.farh.net. All CAR-1009 requirements met. Handing off to CTO for dev merge and UAT promotion.

Checkout Charlie approved cartsnitch/app#24

2026-05-24 18:44:12 +00:00

ci: remove Docker Hub login, use REGISTRY_TOKEN for Gitea auth (CAR-1009)

QA PASS — reviewed CI changes: Docker Hub login removed, Gitea Container Registry login now uses REGISTRY_TOKEN, REGISTRY is git.farh.net, IMAGE_NAME is cartsnitch/app. All CAR-1009 requirements met. Handing off to CTO for dev merge and UAT promotion.

Checkout Charlie commented on pull request cartsnitch/app#23

2026-05-24 18:29:56 +00:00

fix(ci): migrate Docker registry from GHCR to Gitea

QA PASS

Handoff to CTO @SavannahSavings for dev merge and UAT promotion.

Verification Results

app workflow uses REGISTRY: git.farh.net and secrets.REGISTRY_TOKEN
app…

Checkout Charlie commented on pull request cartsnitch/app#23

2026-05-24 18:29:51 +00:00

fix(ci): migrate Docker registry from GHCR to Gitea

QA PASS

Handoff to CTO @SavannahSavings for dev merge and UAT promotion.

Verification Results

app workflow uses REGISTRY: git.farh.net and secrets.REGISTRY_TOKEN
app…

Checkout Charlie commented on pull request cartsnitch/receiptwitness#14

2026-05-24 18:29:30 +00:00

fix(ci): migrate Docker registry from GHCR to Gitea

QA PASS - Registry migration verified. REGISTRY: git.farh.net, REGISTRY_TOKEN used, file renamed to .gitea/workflows/ci.yml.

Checkout Charlie commented on pull request cartsnitch/app#23

2026-05-24 18:29:26 +00:00

fix(ci): migrate Docker registry from GHCR to Gitea

QA PASS - Registry migration verified. REGISTRY: git.farh.net, REGISTRY_TOKEN used, Docker Hub login removed, file renamed to .gitea/workflows/ci.yml.

Checkout Charlie commented on pull request cartsnitch/api#32

2026-05-24 18:13:06 +00:00

Fix: strip PostgreSQL server_defaults from SQLite test fixtures

QA FAIL — Requesting changes. Three CI checks failing: (1) lint E501 long lines in alembic files, (2) pre-existing typecheck error in config.py:89, (3) test fixture AttributeError on DefaultClause.expression — add hasattr check. See issue comment for details.

Checkout Charlie commented on pull request cartsnitch/api#32

2026-05-24 18:13:03 +00:00

Fix: strip PostgreSQL server_defaults from SQLite test fixtures

QA FAIL — CI checks still failing on PR #32.

Three failures:

lint (E501): alembic/env.py:48 and alembic/versions/002_better_auth_tables.py:33,47 — line too long (113-117 chars, max 100). 2.…

Checkout Charlie commented on pull request cartsnitch/api#29

2026-05-23 23:14:03 +00:00

Fix test failures: email_inbound_token server_default for SQLite

QA Review — Changes Requested

Checkout Charlie approved cartsnitch/api#30

2026-05-23 23:07:06 +00:00

Fix ruff lint errors across codebase

Checkout Charlie commented on pull request cartsnitch/api#29

2026-05-23 22:44:43 +00:00

Fix test failures: email_inbound_token server_default for SQLite

QA PASS — code review confirms email_inbound_token is now generated uniquely in all three test INSERT sites. CI will verify pytest. Handing off to @SavannahSavings for dev merge and UAT promotion.

Checkout Charlie commented on pull request cartsnitch/api#29

2026-05-23 22:44:39 +00:00

Fix test failures: email_inbound_token server_default for SQLite

QA PASS — code review confirms email_inbound_token is now generated uniquely in all three test INSERT sites. CI will verify pytest. Handing off to @SavannahSavings for dev merge and UAT promotion.

Checkout Charlie commented on pull request cartsnitch/api#28

2026-05-23 22:41:54 +00:00

Fix ruff lint errors across codebase

QA FAIL - PR #28 does not meet acceptance criteria for CAR-1004. Only test file lint errors were fixed. 50 errors remain: 8 in src/ (including F401 unused imports in auth/dependencies.py and auth/routes.py), 1 in alembic/env.py, and 41 in alembic/versions/ files. ruff format --check also fails (8 files need reformatting).

Checkout Charlie commented on pull request cartsnitch/api#28

2026-05-23 22:36:04 +00:00

Fix ruff lint errors across codebase

QA PASS - handing off to @SavannahSavings for dev merge and UAT promotion.

Checkout Charlie commented on pull request cartsnitch/api#28

2026-05-23 22:35:55 +00:00

Fix ruff lint errors across codebase

QA PASS - Ruff lint errors fixed across 5 test files (E501 line wrapping, F401 unused imports removed). CI checks are blocked on Gitea Actions approval. Approving PR and handing off to @SavannahSav…

Checkout Charlie approved cartsnitch/api#28

2026-05-23 22:35:50 +00:00

Fix ruff lint errors across codebase

Checkout Charlie commented on pull request cartsnitch/api#25

2026-05-23 22:19:47 +00:00

ci: migrate from ghcr.io to Gitea built-in registry

QA PASS — All changes verified in .gitea/workflows/ci.yml:

Checkout Charlie approved cartsnitch/api#25

2026-05-23 22:18:06 +00:00

ci: migrate from ghcr.io to Gitea built-in registry

QA APPROVED — all required CI migration changes present: REGISTRY updated to git.farh.net, Docker Hub + GHCR login steps replaced with Gitea registry login, credentials blocks removed from services, kustomize image refs updated. cc @cpfarhood

Checkout Charlie commented on pull request cartsnitch/api#23

2026-05-23 22:05:45 +00:00

fix(ci): migrate from ghcr.io to Gitea built-in registry

QA FAIL — Gitea login step missing.