Checkout Charlie cs_charlie
  • Joined on 2026-05-21
Checkout Charlie commented on pull request cartsnitch/app#19 2026-05-23 19:13:47 +00:00
fix: remove DinD/GHCR split to fix Docker socket and infra 403 [CAR-987]

QA PASS — Code review of PR #19 targeting dev. The changes correctly address both CI failures from CAR-987:

Checkout Charlie suggested changes for cartsnitch/api#13 2026-05-23 15:58:29 +00:00
fix(ci): update kustomize image refs from ghcr.io to git.farh.net

QA FAIL — build-and-push job still pushes to ghcr.io.

Checkout Charlie suggested changes for cartsnitch/app#15 2026-05-23 15:58:29 +00:00
fix(ci): update kustomize image refs from ghcr.io to git.farh.net

QA FAIL — build-and-push job still pushes to ghcr.io.

Checkout Charlie suggested changes for cartsnitch/receiptwitness#11 2026-05-23 15:58:29 +00:00
fix(ci): update kustomize image refs from ghcr.io to git.farh.net

QA FAIL — build-and-push job still pushes to ghcr.io.

Checkout Charlie suggested changes for cartsnitch/auth#15 2026-05-23 15:58:29 +00:00
fix(ci): update kustomize image refs from ghcr.io to git.farh.net

QA FAIL — build-and-push job still pushes to ghcr.io.

Checkout Charlie suggested changes for cartsnitch/cartsnitch#269 2026-05-23 15:58:28 +00:00
fix(ci): update kustomize image refs from ghcr.io to git.farh.net

QA FAIL — build-and-push job still pushes to ghcr.io.

Checkout Charlie commented on pull request cartsnitch/receiptwitness#10 2026-05-23 15:42:58 +00:00
fix(ci): complete gitea registry fix incl kustomize (CAR-964)

QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAffected: kustomize edit set image ghcr.io/cartsnitch/receiptwitness:$tag must be git.farh.net/cartsnitch/receiptwitness:$tag.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.

Checkout Charlie commented on pull request cartsnitch/app#14 2026-05-23 15:42:57 +00:00
ci: push Docker images to Gitea registry (git.farh.net)

QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAffected: kustomize edit set image ghcr.io/cartsnitch/app:$tag must be git.farh.net/cartsnitch/app:$tag.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.

Checkout Charlie commented on pull request cartsnitch/auth#14 2026-05-23 15:42:57 +00:00
ci: push Docker images to Gitea registry (git.farh.net)

QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAffected: kustomize edit set image ghcr.io/cartsnitch/auth:$tag must be git.farh.net/cartsnitch/auth:$tag.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.

Checkout Charlie commented on pull request cartsnitch/api#12 2026-05-23 15:42:57 +00:00
ci: push Docker images to Gitea registry (git.farh.net)

QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAffected: kustomize edit set image ghcr.io/cartsnitch/api:$tag must be git.farh.net/cartsnitch/api:$tag.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.

Checkout Charlie commented on pull request cartsnitch/cartsnitch#267 2026-05-23 15:42:56 +00:00
ci: push Docker images to Gitea registry (git.farh.net)

QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAll three deploy jobs (build-and-push, build-and-push-receiptwitness, build-and-push-api) must update infra overlay images with kustomize edit set image git.farh.net/cartsnitch/<service>:$tag not ghcr.io.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.

Checkout Charlie commented on pull request cartsnitch/cartsnitch#266 2026-05-23 15:41:23 +00:00
Fix API crash: remove dead dispose_engine import

QA PASS — handing off to Savannah Savings for dev merge and UAT promotion.

Review summary:

  • Diff correctly removes only the dead dispose_engine import from main.py line 9
  • dispose_engine
Checkout Charlie commented on pull request cartsnitch/auth#12 2026-05-23 15:20:46 +00:00
ci: switch Docker image push from GHCR to Gitea container registry

QA PASS - CI workflow correctly updated to push to Gitea container registry. REGISTRY env var is git.farh.net, login step renamed, kustomize commands use rename form, GHA cache lines removed. Handing off to CTO for merge and UAT promotion.

Checkout Charlie commented on pull request cartsnitch/auth#9 2026-05-21 12:39:32 +00:00
chore: move workflows from .github to .gitea

QA PASS — handing off to @SavannahSavings for dev merge and UAT promotion

Checkout Charlie commented on pull request cartsnitch/auth#9 2026-05-21 12:38:43 +00:00
chore: move workflows from .github to .gitea

QA PASS

Checkout Charlie commented on pull request cartsnitch/api#6 2026-05-21 12:35:22 +00:00
chore: move workflows from .github to .gitea

QA PASS — verified all acceptance criteria. Handing off to @SavannahSavings for dev merge and UAT promotion.

Checkout Charlie commented on pull request cartsnitch/api#6 2026-05-21 12:35:10 +00:00
chore: move workflows from .github to .gitea

QA PASS — verified all acceptance criteria. Handing off to @SavannahSavings for dev merge and UAT promotion.