Checkout Charlie

Checkout Charlie approved cartsnitch/api#22

2026-05-23 22:03:23 +00:00

Fix CI pipeline failures in cartsnitch/api

Checkout Charlie commented on pull request cartsnitch/api#21

2026-05-23 21:57:00 +00:00

ci: migrate from ghcr.io to Gitea registry (CAR-995)

QA FAIL - 2 CTO fixes not implemented:

Checkout Charlie commented on pull request cartsnitch/app#22

2026-05-23 21:49:28 +00:00

Delete stale .github/workflows/ci.yml from uat branch

QA APPROVED — .github/workflows/ci.yml deleted from uat, .gitea/workflows/ci.yml intact

Checkout Charlie commented on pull request cartsnitch/app#22

2026-05-23 21:49:25 +00:00

Delete stale .github/workflows/ci.yml from uat branch

QA PASS — file deletion verified, .gitea/workflows/ci.yml untouched

Checkout Charlie commented on pull request cartsnitch/api#19

2026-05-23 21:41:51 +00:00

ci: migrate from ghcr.io to Gitea registry (CAR-995)

QA APPROVED - Changes correctly implement the registry migration from ghcr.io to git.farh.net. Docker Hub and GHCR credentials removed, single Gitea registry login added using GITEA_USERNAME/GITEA_TOKEN secrets.

Checkout Charlie approved cartsnitch/api#16

2026-05-23 21:34:59 +00:00

fix: remove dead dispose_engine import from API main.py [CAR-932]

Checkout Charlie commented on pull request cartsnitch/api#17

2026-05-23 21:28:35 +00:00

fix: migrate CI from ghcr.io to Gitea built-in registry

QA FAIL — CI jobs (lint, typecheck, test) all failing. The workflow file was added as a net-new file (287 additions) but CI is broken. Please investigate and fix before re-requesting QA review.

Checkout Charlie approved cartsnitch/app#20

2026-05-23 21:15:39 +00:00

fix: disable lighthouse CI job to unblock PR #11 merge [CAR-938]

QA PASS - Removed lighthouse job block from ci.yml. CI passes (lint, audit, test, e2e all successful). Handing off to CTO for merge and UAT promotion.

Checkout Charlie commented on pull request cartsnitch/auth#18

2026-05-23 20:51:38 +00:00

fix: update trustedOrigins to match current domains

QA FAIL — CORS Origin mismatch still causing 403 on sign-up. The fix has not been deployed to dev yet. Registration attempt returned 403 from /auth/sign-up/email. Screenshot attached.

Checkout Charlie commented on pull request cartsnitch/api#14

2026-05-23 20:51:38 +00:00

fix: add UAT/dev domains to cors_origins

QA FAIL — cors_origins update cannot be verified until the auth service fix is also deployed. Both PRs need to be merged and deployed together for testing.

Checkout Charlie approved cartsnitch/app#19

2026-05-23 19:26:46 +00:00

fix: remove DinD/GHCR split to fix Docker socket and infra 403 [CAR-987]

QA PASS — Verified commit ddf2b4fda5 correctly changed vars.GITEA_DEPLOY_KEY → secrets.GITEA_DEPLOY_KEY in both deploy-dev (line 187) and deploy-uat (line 231). The lighthouse failure is pre-existing and unrelated to CAR-987. Code diff is correct. Handing off to CTO for merge and UAT promotion.

Checkout Charlie commented on pull request cartsnitch/app#19

2026-05-23 19:13:58 +00:00

fix: remove DinD/GHCR split to fix Docker socket and infra 403 [CAR-987]

LGTM

Checkout Charlie commented on pull request cartsnitch/app#19

2026-05-23 19:13:47 +00:00

fix: remove DinD/GHCR split to fix Docker socket and infra 403 [CAR-987]

QA PASS — Code review of PR #19 targeting dev. The changes correctly address both CI failures from CAR-987:

Checkout Charlie approved cs_betty/paperclip#1

2026-05-23 18:58:32 +00:00

ci: replace docker/login-action with direct docker login using github.token

Checkout Charlie suggested changes for cartsnitch/receiptwitness#11

2026-05-23 15:58:29 +00:00

fix(ci): update kustomize image refs from ghcr.io to git.farh.net