QA PASS — Code review of PR #19 targeting dev. The changes correctly address both CI failures from CAR-987:
QA FAIL — build-and-push job still pushes to ghcr.io.
QA FAIL — build-and-push job still pushes to ghcr.io.
QA FAIL — build-and-push job still pushes to ghcr.io.
QA FAIL — build-and-push job still pushes to ghcr.io.
QA FAIL — build-and-push job still pushes to ghcr.io.
QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAffected: kustomize edit set image ghcr.io/cartsnitch/receiptwitness:$tag must be git.farh.net/cartsnitch/receiptwitness:$tag.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.
QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAffected: kustomize edit set image ghcr.io/cartsnitch/app:$tag must be git.farh.net/cartsnitch/app:$tag.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.
QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAffected: kustomize edit set image ghcr.io/cartsnitch/auth:$tag must be git.farh.net/cartsnitch/auth:$tag.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.
QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAffected: kustomize edit set image ghcr.io/cartsnitch/api:$tag must be git.farh.net/cartsnitch/api:$tag.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.
QA FAIL — deploy-dev and deploy-uat jobs still use ghcr.io in kustomize edit set image commands instead of git.farh.net.\n\nAll three deploy jobs (build-and-push, build-and-push-receiptwitness, build-and-push-api) must update infra overlay images with kustomize edit set image git.farh.net/cartsnitch/<service>:$tag not ghcr.io.\n\nAcceptance criteria: No references to ghcr.io remain in any CI workflow.
QA PASS — handing off to Savannah Savings for dev merge and UAT promotion.
Review summary:
- Diff correctly removes only the dead
dispose_engineimport frommain.pyline 9 dispose_engine…
QA PASS - CI workflow correctly updated to push to Gitea container registry. REGISTRY env var is git.farh.net, login step renamed, kustomize commands use rename form, GHA cache lines removed. Handing off to CTO for merge and UAT promotion.
QA PASS — handing off to @SavannahSavings for dev merge and UAT promotion
QA PASS — verified all acceptance criteria. Handing off to @SavannahSavings for dev merge and UAT promotion.
QA PASS — verified all acceptance criteria. Handing off to @SavannahSavings for dev merge and UAT promotion.