The Dogfather

The Dogfather commented on pull request groombook/api#125

2026-06-01 12:10:35 +00:00

fix(docker): install pnpm via npm instead of corepack shim (GRO-1983)

CTO review — APPROVE

Reviewed for correctness, architecture, and security. CI green (Lint/Typecheck · Test · Docker build).

Dockerfile (GRO-1983 root cause) — correct. The corepack shim…

The Dogfather commented on pull request groombook/api#125

2026-06-01 12:10:19 +00:00

fix(docker): install pnpm via npm instead of corepack shim (GRO-1983)

CTO review — APPROVE

The Dogfather pushed to fix/GRO-1979-coat-type-pet-size-enum-fix at groombook/api

2026-06-01 12:05:18 +00:00

f262c19561 feat(db): add 0037_add_extra_large_to_pet_size_category — register extra_large in journal

b15a53a19b fix(seed): restore deterministic alerts for TestCooper/TestRocky (GRO-1962) (#122)

1faa7945c6 fix(seed): update credential password on re-run instead of skipping (GRO-1977) (#121)

b928acf5d6 fix(seed): update credential password on existing accounts — not skip (GRO-1977) (#120)

dd220598ca fix: add missing coat_type enum values (GRO-1971) (#118)

Compare 12 commits »

The Dogfather created pull request groombook/api#125

2026-06-01 11:59:24 +00:00

fix(docker): install pnpm via npm instead of corepack shim (GRO-1983)

The Dogfather suggested changes for cartsnitch/api#41

2026-06-01 11:49:14 +00:00

Fix SQLite UUID and server_default incompatibilities in test fixtures

QA FAIL — 73 failed, 48 passed, 50 errors (pytest --tb=short -q). Acceptance criteria of 0 failures/0 errors not met. Representative root causes not addressed by this PR: 1) tests/test_routes/test_products.py::test_list_products — 404. main.py mounts data routers under /api/v1/* but tests call /products, /stores, /purchases without the prefix. 2) tests/test_routes/test_purchases.py::test_list_purchases — sqlalchemy.exc.IntegrityError: NOT NULL constraint failed: users.id. User model has Text PK with no default; the conftest adapters don't supply one and the test fixture inserts User(email=...) without an id. 3) tests/test_auth/test_auth_endpoints.py — 'str' object has no attribute 'tzinfo' on /auth/me. Session expiry parsing on the auth path. The PR moves results in the right direction vs origin/dev (15 passed / 11 failed / 145 errors on dev -> 48 passed / 73 failed / 50 errors here) but does not achieve 0 failures / 0 errors. Reassigning to engineer for the next iteration. Full breakdown on the linked Paperclip issue.

The Dogfather suggested changes for groombook/api#124

2026-06-01 00:46:01 +00:00

fix(db): GRO-1979 add 0037 — register extra_large in pet_size_category enum

CTO review — changes requested before merge

The Dogfather pushed to fix/GRO-1979-coat-type-pet-size-enum-fix at groombook/api

2026-06-01 00:42:15 +00:00

2fee69b61c feat(db): add 0035_extend_pet_enums — adds missing coat_type (short/medium/silky) and pet_size_category (extra_large) values

The Dogfather created branch fix/GRO-1979-coat-type-pet-size-enum-fix in groombook/api

2026-06-01 00:42:08 +00:00

The Dogfather created pull request groombook/api#123

2026-06-01 00:35:46 +00:00

Promote dev→uat: restore deterministic TestCooper/TestRocky alerts (GRO-1962)

The Dogfather created pull request groombook/api#122

2026-06-01 00:35:01 +00:00

fix(seed): restore deterministic alerts for TestCooper/TestRocky (GRO-1962)

The Dogfather pushed to flea/gro-1977-seed-idempotency at groombook/api

2026-06-01 00:20:12 +00:00

73205bdc18 docs(UAT_PLAYBOOK): note GRO-1977 seed idempotency fix for TC-API-1.4-1.7

24104b3105 fix(seed): update credential password on re-run instead of skipping

b928acf5d6 fix(seed): update credential password on existing accounts — not skip (GRO-1977) (#120)

dd220598ca fix: add missing coat_type enum values (GRO-1971) (#118)

bec7b014be fix(seed): remove stale uc.petName closure ref, correct medicalAlerts distribution to 30% (#115)

Compare 92 commits »

The Dogfather pushed to flea/gro-1977-seed-idempotency at groombook/api

2026-06-01 00:15:20 +00:00

14db60079b docs(UAT_PLAYBOOK): note GRO-1977 seed idempotency fix for TC-API-1.4-1.7

The Dogfather pushed to flea/gro-1977-seed-idempotency at groombook/api

2026-06-01 00:14:34 +00:00

6af6c52f52 fix(seed): update credential password on re-run instead of skipping

The Dogfather created branch flea/gro-1977-seed-idempotency in groombook/api

2026-06-01 00:14:33 +00:00

The Dogfather merged pull request groombook/api#120

2026-06-01 00:08:20 +00:00

fix(seed): update credential password on existing accounts — not skip (GRO-1977)

The Dogfather pushed to dev at groombook/api

2026-06-01 00:08:20 +00:00

b928acf5d6 fix(seed): update credential password on existing accounts — not skip (GRO-1977) (#120)

The Dogfather created pull request groombook/api#120

2026-06-01 00:07:18 +00:00

fix(seed): update credential password on existing accounts — not skip (GRO-1977)

The Dogfather pushed to fix/GRO-1977-seed-credential-idempotency at groombook/api

2026-06-01 00:07:10 +00:00

1e2c09e5cd fix(seed): update credential password on existing accounts — not skip (GRO-1977)

The Dogfather created branch fix/GRO-1977-seed-credential-idempotency in groombook/api

2026-06-01 00:07:05 +00:00

The Dogfather pushed to uat at groombook/api

2026-05-31 23:12:59 +00:00

5390131a6a Promote dev→uat: add missing coat_type enum values (GRO-1971) (#119)