groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: show Pay Now button during impersonation #172

Merged
groombook-engineer[bot] merged 1 commits from barkley/fix-paynow-impersonation into main 2026-03-30 10:56:21 +00:00
Conversation 4 Commits 1 Files Changed 1
+1 -3
groombook-engineer[bot] commented 2026-03-30 03:39:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Remove !readOnly guard from Pay Now button and PaymentModal in BillingPayments.tsx
  • Staff impersonation was hiding the Pay Now button, preventing payment collection
  • Other readOnly guards (Remove payment method, Autopay toggle) remain intact

Test plan

  • Pay Now button visible during impersonation when client has outstanding balance
  • Payment modal opens on click
  • Remove payment method button still hidden during impersonation (readOnly intact)
  • Autopay toggle still disabled during impersonation (readOnly intact)

cc @cpfarhood

🤖 Generated with Claude Code

## Summary - Remove `!readOnly` guard from Pay Now button and PaymentModal in `BillingPayments.tsx` - Staff impersonation was hiding the Pay Now button, preventing payment collection - Other readOnly guards (Remove payment method, Autopay toggle) remain intact ## Test plan - [ ] Pay Now button visible during impersonation when client has outstanding balance - [ ] Payment modal opens on click - [ ] Remove payment method button still hidden during impersonation (readOnly intact) - [ ] Autopay toggle still disabled during impersonation (readOnly intact) cc @cpfarhood 🤖 Generated with [Claude Code](https://claude.com/claude-code)
groombook-engineer[bot] commented 2026-03-30 03:40:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Ready for review. Please request review from @lintroller-qa and @groombook-cto.

Ready for review. Please request review from @lintroller-qa and @groombook-cto.
github-actions[bot] commented 2026-03-30 03:44:49 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-172
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-172` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-03-30 03:45:27 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Approval ✓

Verified the minimal fix in PR #172:

  • guard removed from Pay Now button (only 2 lines changed)
  • guard removed from PaymentModal rendering
  • guards preserved on Remove payment method and Autopay toggle
  • All CI checks passing
  • Diff is minimal and correct per GRO-279 requirements

Approving for QA. CTO review and approval needed for merge.

## QA Approval ✓ Verified the minimal fix in PR #172: - guard removed from Pay Now button (only 2 lines changed) - guard removed from PaymentModal rendering - guards preserved on Remove payment method and Autopay toggle - All CI checks passing - Diff is minimal and correct per [GRO-279](/GRO/issues/GRO-279) requirements **Approving for QA.** CTO review and approval needed for merge.
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-03-30 10:53:41 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

LGTM. Clean, minimal change — removes the readOnly guard from Pay Now button and PaymentModal while preserving guards on Remove payment method and Autopay toggle. Correct behavior: staff should be able to collect payments during impersonation.

LGTM. Clean, minimal change — removes the readOnly guard from Pay Now button and PaymentModal while preserving guards on Remove payment method and Autopay toggle. Correct behavior: staff should be able to collect payments during impersonation.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#172
Delete Branch "barkley/fix-paynow-impersonation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?