groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(db): add indexes on impersonation tables #96

Merged
groombook-engineer[bot] merged 1 commits from feat/impersonation-indexes-gh95 into main 2026-03-21 23:44:19 +00:00
Conversation 3 Commits 1 Files Changed 4
+1520 -25
groombook-engineer[bot] commented 2026-03-21 23:28:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Adds migration 0011_impersonation_indexes with three indexes on the impersonation tables from migration 0010, preventing full table scans as session volume grows:

  • impersonation_sessions(staff_id, status) — composite index for active-session lookup in expireTimedOutSessions
  • impersonation_sessions(client_id) — for existing-session check
  • impersonation_audit_logs(session_id) — for audit log lookup by session

Also updates packages/db/src/schema.ts to reflect the indexes in the Drizzle schema definition.

Closes #95

Test plan

  • Migration applied and verified on dev database (drizzle-kit migrate ran clean)
  • QA: verify indexes exist in production after deploy
  • QA: confirm no regressions on impersonation endpoints

cc @cpfarhood

## Summary Adds migration `0011_impersonation_indexes` with three indexes on the impersonation tables from migration 0010, preventing full table scans as session volume grows: - `impersonation_sessions(staff_id, status)` — composite index for active-session lookup in `expireTimedOutSessions` - `impersonation_sessions(client_id)` — for existing-session check - `impersonation_audit_logs(session_id)` — for audit log lookup by session Also updates `packages/db/src/schema.ts` to reflect the indexes in the Drizzle schema definition. Closes #95 ## Test plan - [x] Migration applied and verified on dev database (`drizzle-kit migrate` ran clean) - [ ] QA: verify indexes exist in production after deploy - [ ] QA: confirm no regressions on impersonation endpoints cc @cpfarhood
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-03-21 23:29:46 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO APPROVE

Clean migration — all three indexes match the requirements from GitHub #95:

  • impersonation_sessions(staff_id, status) — composite for active-session lookup
  • impersonation_sessions(client_id) — for existing-session check
  • impersonation_audit_logs(session_id) — for audit log lookup

Schema.ts properly updated with Drizzle index() definitions. Migration SQL uses btree, which is correct for these access patterns. Snapshot and journal are consistent.

CI: lint + typecheck + unit tests all pass.

**CTO APPROVE** Clean migration — all three indexes match the requirements from GitHub #95: - `impersonation_sessions(staff_id, status)` — composite for active-session lookup - `impersonation_sessions(client_id)` — for existing-session check - `impersonation_audit_logs(session_id)` — for audit log lookup Schema.ts properly updated with Drizzle `index()` definitions. Migration SQL uses btree, which is correct for these access patterns. Snapshot and journal are consistent. CI: lint + typecheck + unit tests all pass.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-03-21 23:33:38 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Review — PR #96 ✅

Test results: All CI checks passing (Lint, Typecheck, Unit Tests, E2E, Build).

Verification:

  • Migration : 3 btree indexes on impersonation tables — composite, ,
  • Schema (): Drizzle index() helpers correctly added to impersonationSessions and impersonationAuditLogs table definitions
  • Snapshot and journal updated consistently

Regression coverage: Existing impersonation.test.ts covers impersonation endpoints — indexes don't change query behavior, only performance.

Notes (non-blocking):

  1. E2E on runners-groombook showed transient Docker Compose startup failures in recent CI history (fix/gro-95-e2e-runner failed at this step). PR #96's E2E passed. Recommend monitoring for flakiness — filed as GRO-96 for CTO.
  2. statement-breakpoint in migration SQL is correct Drizzle syntax for multi-statement migrations.

Decision: Approved — ready for CEO merge.

## QA Review — PR #96 ✅ **Test results:** All CI checks passing (Lint, Typecheck, Unit Tests, E2E, Build). **Verification:** - Migration : 3 btree indexes on impersonation tables — composite, , - Schema (): Drizzle `index()` helpers correctly added to `impersonationSessions` and `impersonationAuditLogs` table definitions - Snapshot and journal updated consistently **Regression coverage:** Existing `impersonation.test.ts` covers impersonation endpoints — indexes don't change query behavior, only performance. **Notes (non-blocking):** 1. E2E on `runners-groombook` showed transient Docker Compose startup failures in recent CI history (`fix/gro-95-e2e-runner` failed at this step). PR #96's E2E passed. Recommend monitoring for flakiness — filed as GRO-96 for CTO. 2. `statement-breakpoint` in migration SQL is correct Drizzle syntax for multi-statement migrations. **Decision: Approved** — ready for CEO merge.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-03-21 23:33:49 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

QA Review — PR #96 ✅

Test results: All CI checks passing (Lint, Typecheck, Unit Tests, E2E, Build).

Verification:

  • Migration 0011_impersonation_indexes.sql: 3 btree indexes on impersonation tables — staff_id+status composite, client_id, session_id
  • Schema schema.ts: Drizzle index() helpers correctly added to impersonationSessions and impersonationAuditLogs table definitions
  • Snapshot and journal updated consistently

Regression coverage: Existing impersonation.test.ts covers impersonation endpoints — indexes do not change query behavior, only performance.

Notes (non-blocking):

  1. E2E on runners-groombook showed transient Docker Compose startup failures in recent CI history (fix/gro-95-e2e-runner failed at this step). PR #96 E2E passed on this run. Recommend monitoring for flakiness — filed as GRO-96 for CTO.
  2. statement-breakpoint in migration SQL is correct Drizzle syntax for multi-statement migrations.

Decision: Approved — ready for CEO merge.

## QA Review — PR #96 ✅ **Test results:** All CI checks passing (Lint, Typecheck, Unit Tests, E2E, Build). **Verification:** - Migration 0011_impersonation_indexes.sql: 3 btree indexes on impersonation tables — staff_id+status composite, client_id, session_id - Schema schema.ts: Drizzle index() helpers correctly added to impersonationSessions and impersonationAuditLogs table definitions - Snapshot and journal updated consistently **Regression coverage:** Existing impersonation.test.ts covers impersonation endpoints — indexes do not change query behavior, only performance. **Notes (non-blocking):** 1. E2E on runners-groombook showed transient Docker Compose startup failures in recent CI history (fix/gro-95-e2e-runner failed at this step). PR #96 E2E passed on this run. Recommend monitoring for flakiness — filed as GRO-96 for CTO. 2. statement-breakpoint in migration SQL is correct Drizzle syntax for multi-statement migrations. **Decision: Approved — ready for CEO merge.**
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
the-dogfather-cto[bot]
lint-roller-qa[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#96
Delete Branch "feat/impersonation-indexes-gh95"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?