promote: dev → uat (GRO-1207 portal Communication tab real backend) #408

Merged
the-dogfather-cto[bot] merged 16 commits from dev into uat 2026-05-14 16:59:10 +00:00

16 Commits

Author SHA1 Message Date
the-dogfather-cto[bot] 795081cf10 Merge pull request #409 from groombook/fleaflicker/add-staff-messages-uat-playbook
docs(UAT_PLAYBOOK): add §4.20 Staff Messages test cases
2026-05-14 16:45:01 +00:00
Chris Farhood 8d5b71dc0f docs(UAT_PLAYBOOK): add §4.20 Staff Messages test cases
Add missing test coverage for the staff Messages page introduced
by PR #405 (GRO-106). Covers inbox load, conversation open,
send message, empty state, unread indicator, and cross-tenant
isolation per QA review on PR #408.

Updated UAT_PLAYBOOK.md §4.20 — staff Messages feature (GRO-106)
2026-05-14 16:37:04 +00:00
the-dogfather-cto[bot] c2d38bd3ee feat(GRO-106): staff messages page (#405)
feat(GRO-106): staff messages page
2026-05-14 16:23:27 +00:00
Chris Farhood 6a7229f330 merge: resolve conflicts with dev (keep API-aligned frontend)
Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-14 16:20:40 +00:00
Chris Farhood 9d9d7da13d fix(GRO-985): fix Messages test mocks and scrollIntoView guard
- Wrap conversation mocks in { items, nextCursor } response shape
  (loadConversations reads json.items, bare array caused undefined.length crash)
- Guard scrollIntoView with ?. (jsdom doesn't implement it)
- Use getAllByText for text appearing in both preview and thread

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-14 16:15:24 +00:00
lint-roller-qa[bot] 2c29c5e4a9 Merge pull request #406 from groombook/flea-flicker/gro-1248-fix-infra-path-prefix
fix(ci): correct infra repo paths in promote workflows
2026-05-14 16:12:51 +00:00
the-dogfather-cto[bot] ba5f8a916d Merge pull request #398 from groombook/feat/GRO-106-portal-communication-real
feat(GRO-106): portal Communication tab — real backend
2026-05-14 16:07:33 +00:00
Chris Farhood e873f11e4f fix(GRO-1241): test and guard scrollIntoView in MessagesPage 2026-05-14 15:46:31 +00:00
Chris Farhood aae11c0c4d fix(GRO-1241): remove unused readOnly and senderName in Communication.tsx
- Rename readOnly to _readOnly in MessageThread destructuring
  (satisfies ESLint no-unused-vars rule)
- Remove unused senderName variable in messages map

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-14 15:26:03 +00:00
Chris Farhood 537b5cb0b3 fix(GRO-1241): resolve all CI failures from QA review
1. **Remove duplicate staffReadAt** in `packages/db/src/schema.ts`
   (TS1117 duplicate identifier — merge conflict artifact)

2. **Add count to db index exports** in `packages/db/src/index.ts`
   (`count` from drizzle-orm was used in conversations.ts but not exported)

3. **Use dev version of conversations.ts** (no type errors, sql\`count(*)\`)
   — PR branch version had incompatible type errors (staff.businessId,
   count, optedOutAt fields not in schema)

4. **Remove duplicate conversationsRouter import** in `apps/api/src/index.ts`

All 289 tests pass, 0 lint errors.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-14 14:46:52 +00:00
Chris Farhood d60200f8a7 fix(GRO-1241): remove duplicate staffReadAt + add count mock
- Remove duplicate staffReadAt column in conversations table schema
  (merge conflict artifact — TS1117 duplicate definition)
- Add count mock to conversations.test.ts mock @groombook/db export
  (PR switched from sql\`count(*)\` to Drizzle count() without updating mock)

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-14 14:30:58 +00:00
Chris Farhood f150663047 fix(ci): correct infra repo paths in promote workflows
Replace incorrect `apps/groombook/` path prefix with `apps/` in both
promote-to-uat.yml and promote-prod.yml. The infra repo structure uses
`apps/` directly without a `groombook/` level.

GRO-1248

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-14 14:00:12 +00:00
Chris Farhood e605e1be74 fix(GRO-1242): align Messages frontend with conversations API contract
- Extract Conversation interface fields to match API response:
  replace lastMessageBody with lastMessage object, externalNumber with
  clientPhone, remove staffReadAt
- loadConversations(): extract json.items array instead of raw array
- loadMessages(): extract json.items and reverse() for chronological order
- Update test mocks to use { items, nextCursor } response shape

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-14 13:02:47 +00:00
Chris Farhood c4978be280 feat(GRO-106): staff messages page
- Adds staff conversations API (GET /api/conversations, GET /api/conversations/:id/messages, POST /api/conversations/:id/messages) with auth scoping and cross-tenant protection
- Adds staffReadAt column to conversations table for unread tracking
- Adds staff Messages page with two-column inbox layout (thread list + conversation view + composer)
- Adds Messages entry to staff sidebar navigation
- Includes tests for the MessagesPage component

Part of GRO-106 (SMS/MMS integration) Phase 1.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-14 12:41:35 +00:00
Chris Farhood f43e566dbd fix(GRO-1215): resolve ESLint error, cursor pagination, and UAT playbook gaps
- Add and() + lt() imports from @groombook/db
- Apply businessId to conversation WHERE clause for cross-tenant isolation
  (GET /portal/conversation: clientId AND businessId both scoped)
- Fix cursor pagination: apply lt(messages.createdAt, cursorMsg.createdAt)
  to the cursor WHERE clause so pages actually paginate
- Add UAT_PLAYBOOK.md §4.9.1 Communication tab test cases:
  TC-APP-4.9.6 message history with conversation
  TC-APP-4.9.7 empty state (no conversation yet)
  TC-APP-4.9.8 composer disabled with tooltip
  TC-APP-4.9.9 cross-tenant isolation

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-14 12:40:06 +00:00
Chris Farhood 9c9568b80c feat(GRO-106): portal Communication tab — real backend
- Added GET /portal/conversation and GET /portal/conversation/messages endpoints
- Created Communication.api.ts with typed fetchers and React hooks
- Rewired Communication.tsx to use real API, removed mock data
- Added composer-disabled bar with "Reply from your phone" tooltip
- Added conversation route tests to portal.test.ts

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-14 12:40:06 +00:00