privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

fix: align volume name in deploy-e2e-headlamp.sh #64

Closed
privilegedescalation-engineer[bot] wants to merge 10 commits from hugh/kube-vip-e2e-final into main
pull from: hugh/kube-vip-e2e-final
merge into: privilegedescalation:main
Conversation 6 Commits 10 Files Changed 4
+288 -486

10 Commits

Author SHA1 Message Date
Chris Farhood 1d8fa360f7 chore: re-trigger CI after fix commit 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-06 21:55:06 +00:00
Chris Farhood 40fc7b08de fix: align deploy-e2e-headlamp.sh to kube-vip plugin 
- Fix comment referencing 'rook' -> 'kube-vip'
- Add error handling for kubectl apply failure
- Add cluster state dump on apply failure
- Align automountServiceAccountToken to match other plugins
- Remove spurious sleep 2 before rollout status

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-06 21:12:37 +00:00
Chris Farhood 3080e84a2b fix: correct volume name from rook-plugin to headlamp-kube-vip-plugin 
The deploy script had hardcoded 'rook-plugin' as the volume name
but should be 'headlamp-kube-vip-plugin' to match the ConfigMap.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-06 18:49:08 +00:00
Chris Farhood d9a505f34c Update e2e.yaml to use @main and pass plugin-name 
Use @main workflow ref and add plugin-name input so the
reusable workflow can derive ConfigMap name and mount path.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-05 19:30:45 +00:00
Chris Farhood f2b138f357 fix(e2e): disable automount SA token to avoid kubelet fetch race 
Kubelet tries to fetch SA token immediately after deployment creates the pod,
but the SA may not be propagated yet. Setting automountServiceAccountToken: false
avoids this race. The SA token is not needed since E2E tests authenticate
via HEADLAMP_TOKEN passed as env var.
 2026-05-05 18:46:47 +00:00
Chris Farhood 80e491c68a fix(e2e): use pnpm-capable workflow branch 
Reference @hugh/add-pnpm-support-plugin-e2e which has pnpm support via corepack.

PRI-634
 2026-05-05 17:52:27 +00:00
Chris Farhood 97f27af70e fix(e2e): reference @main workflow after .github merge 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-05 17:43:49 +00:00
Chris Farhood b991268523 fix(ci): guard dual-approval job against null pull_request context 
When triggered by pull_request_review events, github.event.pull_request
is undefined, which can cause issues when the job tries to access
github.event.pull_request.number. Add a job-level if guard to prevent
the job from running in these conditions.

This addresses the dual approval failures seen on feature branches where
the workflow was running without a valid PR context.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-05 17:34:18 +00:00
Chris Farhood d1ff6f3a6b fix(e2e): update plugin-e2e.yaml ref to hugh/fix-e2e-playwright-install-pnpm 
Updates reusable workflow ref to include Playwright cache + retry fix from
PR privilegedescalation/.github#145.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-05 16:59:50 +00:00
Chris Farhood bb93e13024 fix(e2e): add E2E workflow and deploy scripts for headlamp-kube-vip-plugin 
Adds:
- .github/workflows/e2e.yaml (calls plugin-e2e.yaml reusable workflow)
- scripts/deploy-e2e-headlamp.sh (deploys Headlamp with kube-vip plugin ConfigMap)
- scripts/teardown-e2e-headlamp.sh (cleans up E2E resources)

Fixes PRI-729: E2E DNS failure caused by missing E2E workflow in this repo.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-05 15:40:26 +00:00