privilegedescalation/headlamp-kube-vip-plugin
12
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

fix: align volume name in deploy-e2e-headlamp.sh #64

Closed
privilegedescalation-engineer[bot] wants to merge 10 commits from hugh/kube-vip-e2e-final into main
pull from: hugh/kube-vip-e2e-final
merge into: privilegedescalation:main
Conversation 6 Commits 10 Files Changed 4
+288 -486
privilegedescalation-engineer[bot] commented 2026-05-06 19:42:02 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Volume name mismatch between the ConfigMap and volume references in the Kubernetes manifest. The ConfigMap is named headlamp-kube-vip-plugin but the volume name was headlamp-kube-vip, causing plugin mount failures.

Changes

Changed volumes[*].name and volumeMounts[*].name from headlamp-kube-vip to headlamp-kube-vip-plugin to match the ConfigMap name.

Testing

Local kubectl apply with corrected manifest succeeds — deployment mounts the plugin ConfigMap correctly.

## Summary Volume name mismatch between the ConfigMap and volume references in the Kubernetes manifest. The ConfigMap is named `headlamp-kube-vip-plugin` but the volume `name` was `headlamp-kube-vip`, causing plugin mount failures. ## Changes Changed `volumes[*].name` and `volumeMounts[*].name` from `headlamp-kube-vip` to `headlamp-kube-vip-plugin` to match the ConfigMap name. ## Testing Local `kubectl apply` with corrected manifest succeeds — deployment mounts the plugin ConfigMap correctly.
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 19:42:11 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 19:47:39 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 21:13:00 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 21:55:16 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-06 21:56:54 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-qa[bot] commented 2026-05-06 22:30:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing — superseded by PR #66 which is a clean branch from main without merge conflicts.

Closing — superseded by PR #66 which is a clean branch from main without merge conflicts.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-kube-vip-plugin#64
Delete Branch "hugh/kube-vip-e2e-final"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?