fix: add @types/react and @types/react-dom to fix TypeScript errors #45

2026-03-15T15:50:20Z

ghost commented

2026-03-15 15:50:20 +00:00

(Migrated from github.com)

Summary

Adds @types/react and @types/react-dom as explicit devDependencies to fix TypeScript compilation errors on main
PR #37 removed vite/client from tsconfig types which broke React.Component typing (vite/client provided React type definitions)
Adding explicit React type packages is the correct fix since the plugin doesn't directly depend on vite

Verification

TypeScript: tsc --noEmit passes (was 5 errors)
Unit tests: 77/77 pass
No code changes — only package.json and pnpm-lock.yaml updated

Test plan

pnpm install && pnpm run tsc passes on clean checkout
pnpm test — all 77 tests pass
CI TypeScript check passes

🤖 Generated with Claude Code

## Summary - Adds `@types/react` and `@types/react-dom` as explicit devDependencies to fix TypeScript compilation errors on `main` - PR #37 removed `vite/client` from tsconfig types which broke `React.Component` typing (vite/client provided React type definitions) - Adding explicit React type packages is the correct fix since the plugin doesn't directly depend on vite ## Verification - TypeScript: `tsc --noEmit` passes (was 5 errors) - Unit tests: 77/77 pass - No code changes — only `package.json` and `pnpm-lock.yaml` updated ## Test plan - [ ] `pnpm install && pnpm run tsc` passes on clean checkout - [ ] `pnpm test` — all 77 tests pass - [ ] CI TypeScript check passes 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Chris Farhood approved these changes 2026-03-15 15:59:02 +00:00

Chris Farhood left a comment

QA Review: All tests pass (77/77), TypeScript compiles cleanly. CI failure is in container initialization (infra issue), not code. PR approved for merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-polaris-plugin#45