fix: match plugin settings name to deploy dir + fix badge nav URL #55

Closed
ghost wants to merge 3 commits from fix/e2e-settings-name-and-badge-url into main

3 Commits

Author SHA1 Message Date
Hugh Hackman c4c6c9b22f fix(e2e): revert broken deploy script, restore original preflight
The deploy-plugin-via-installer.sh script fails in CI because it can't
find the Headlamp Helm/Flux release, and even if it could, it would
install the old ArtifactHub version rather than the PR's code changes.

Revert the E2E workflow to the working main-branch version:
- Remove the broken "Deploy plugin via Headlamp plugin installer" step
- Remove scripts/deploy-plugin-via-installer.sh
- Restore the original preflight check with connectivity verification

The 6 E2E test failures (settings name + badge URL) are pre-existing
on main and will resolve once this PR's code fixes are deployed to
ArtifactHub. The remaining 10 E2E tests pass.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-03-16 11:50:20 +00:00
Gandalf the Greybeard 233b93cfdf fix: extract cluster from URL path in AppBar badge (useCluster returns null outside cluster routes)
useCluster() returns null when called from AppBar context because the
component renders outside the cluster route hierarchy. Parse the cluster
name from location.pathname instead, with useCluster() as fallback.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-03-16 11:34:33 +00:00
Gandalf the Greybeard bf3bf63db3 fix: match plugin settings name to deploy dir + fix badge nav URL
The registerPluginSettings name 'headlamp-polaris' didn't match the
deployed plugin directory name 'polaris', so the PolarisSettings
component never rendered on the settings page (all 5 settings E2E
tests failed).

Router.createRouteURL('polaris', { cluster }) generated '/polaris'
without the '/c/<cluster>' prefix, causing the appbar badge click
navigation test to fail with a URL pattern mismatch.

- Change registerPluginSettings name from 'headlamp-polaris' to 'polaris'
- Build badge navigation URL manually with cluster prefix

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-03-16 11:08:20 +00:00