privilegedescalation/headlamp-rook-plugin
12
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases 14 Wiki Activity

fix e2e: add missing plugin-name input to plugin-e2e workflow #66

Closed
privilegedescalation-engineer[bot] wants to merge 5 commits from hugh/fix-e2e-plugin-name-20260506123605 into main
pull from: hugh/fix-e2e-plugin-name-20260506123605
merge into: privilegedescalation:main
Conversation 2 Commits 5 Files Changed 2
+13 -7

5 Commits

Author SHA1 Message Date
Chris Farhood 540f0a7890 fix e2e: add missing plugin-name input to plugin-e2e workflow 
The rook plugin E2E workflow was calling the reusable plugin-e2e workflow
without the required plugin-name input. This caused the ConfigMap naming
and mount path to fall back to the headlamp-kube-vip defaults, breaking
E2E runs for the rook plugin.

Fix: pass plugin-name: rook to the reusable workflow.
 2026-05-06 12:36:08 +00:00
Chris Farhood 3f93e71f28 fix(e2e): reference @main workflow after .github merge 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-05 17:43:54 +00:00
Chris Farhood 0d9f9d859a fix(e2e): use .first() to handle strict mode violations (PRI-699) 
Similar to the kube-vip fix, /overview/i and /storage class/i can
match multiple headings. Using .first() to avoid strict mode violations.
 2026-05-05 13:56:35 +00:00
Chris Farhood 61df61c691 fix(e2e): expand storage classes sidebar nav and relax plugin settings locator 
The 'Storage Classes' link is nested under the Rook sidebar button, not
at the top level. Expand the Rook section before asserting visibility.
Also uses /rook/i case-insensitive regex and waits for the plugins list
to render before searching.
 2026-05-05 13:04:45 +00:00
Chris Farhood 15d161c312 fix(e2e): use pnpm-capable workflow branch with namespace param 2026-05-05 12:21:22 +00:00